DescriptionRevert of Shape Detection: move the Mac service to the sandboxed GPU process (patchset #1 id:20001 of https://codereview.chromium.org/2739163003/ )
Reason for revert:
fast/shapedetection/shapedetection-security-test.html seems to get flaky due to this CL on mac bots.
BUG=701675
Original issue's description:
> Shape Detection: move the Mac service to the sandboxed GPU process
>
> ShapeDetection in Mac uses privileged and potentially dangerous APIs
> inside CoreImage and perhaps more, transitively. This CL moves the
> shape detection service to run in the GPU process, which is sandboxed.
>
> The reason for using the GPU process is that CoreImage APIs seem
> to depend strongly and mysteriously on the GPU, as I learned while
> trying to get the unittests to work [1] in our normal mac bots (which
> are virtual machines and have no GPU). I tried using a sw rendering
> context and a coupe of other circumventions but nothing really worked.
>
> [1] early PSs in https://codereview.chromium.org/2677553003/
>
> BUG=666143
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2739163003
> Cr-Commit-Position: refs/heads/master@{#456555}
> Committed: https://chromium.googlesource.com/chromium/src/+/95d98937e0fb0baf11d7c3088a99bb20a58e32cf
TBR=rockot@chromium.org,kbr@chromium.org,rsesek@chromium.org,mcasas@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=666143
Review-Url: https://codereview.chromium.org/2749213002
Cr-Commit-Position: refs/heads/master@{#457035}
Committed: https://chromium.googlesource.com/chromium/src/+/886e0b3390e48ca2dd0a361b9e27b84e73b0acc4
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|