Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2749193004: Show only origin in Reading List URLs. (Closed)

Created:
3 years, 9 months ago by Olivier
Modified:
3 years, 9 months ago
Reviewers:
gambard
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, stkhapugin, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show only origin in Reading List URLs. When URL is used as title, show the full URL as it is used to recognise the entry. BUG=694549 Review-Url: https://codereview.chromium.org/2749193004 Cr-Commit-Position: refs/heads/master@{#457379} Committed: https://chromium.googlesource.com/chromium/src/+/48ea7ece83785f4aa88855400d94bed9ed1f08c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Olivier
3 years, 9 months ago (2017-03-15 14:18:28 UTC) #2
gambard
lgtm
3 years, 9 months ago (2017-03-16 07:53:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749193004/1
3 years, 9 months ago (2017-03-16 08:53:19 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 09:06:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/48ea7ece83785f4aa88855400d94...

Powered by Google App Engine
This is Rietveld 408576698