Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2313)

Unified Diff: ui/base/accelerators/mojo/accelerator.mojom

Issue 2749183005: Adds mojom structure for ui::Accelerator and struct traits (Closed)
Patch Set: nit Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/accelerators/mojo/accelerator.mojom
diff --git a/ui/base/accelerators/mojo/accelerator.mojom b/ui/base/accelerators/mojo/accelerator.mojom
new file mode 100644
index 0000000000000000000000000000000000000000..fd4ca72c573df08e5e2d659443908cb233217833
--- /dev/null
+++ b/ui/base/accelerators/mojo/accelerator.mojom
@@ -0,0 +1,22 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+module ui.mojom;
+
+import "ui/events/mojo/event_constants.mojom";
+import "ui/events/mojo/keyboard_codes.mojom";
+
+enum AcceleratorKeyState {
msw 2017/03/16 22:50:39 nit: comment, mention that this matches ui::Accele
sky 2017/03/16 23:30:46 Done.
+ PRESSED,
+ RELEASED,
+};
+
+// See ui::Accelerator for details on these values.
msw 2017/03/16 22:50:39 optional nit: // This structure matches ui::Accele
sky 2017/03/16 23:30:46 Done.
+struct Accelerator {
+ // Accelerator::key_code_ is a KeyboardCode, but it may also contain other
msw 2017/03/16 22:50:39 optional nit: It might help to elaborate on what o
sky 2017/03/16 23:30:46 Done.
+ // values.
+ int32 key_code;
+ AcceleratorKeyState key_state;
+ int32 modifiers;
+};

Powered by Google App Engine
This is Rietveld 408576698