ui/base/accelerators/mojo/accelerator.mojom - Issue 2749183005: Adds mojom structure for ui::Accelerator and struct traits

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/base/accelerators/mojo/accelerator.mojom

Issue 2749183005: Adds mojom structure for ui::Accelerator and struct traits (Closed)

Patch Set: nit Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module ui.mojom;

	6

	7 import "ui/events/mojo/event_constants.mojom";

	8 import "ui/events/mojo/keyboard_codes.mojom";

	9

	10 enum AcceleratorKeyState {
	msw 2017/03/16 22:50:39 nit: comment, mention that this matches ui::Accele nit: comment, mention that this matches ui::Accelerator::KeyState sky 2017/03/16 23:30:46 Done. Show quoted text On 2017/03/16 22:50:39, msw wrote: > nit: comment, mention that this matches ui::Accelerator::KeyState Done.
	11 PRESSED,

	12 RELEASED,

	13 };

	14

	15 // See ui::Accelerator for details on these values.
	msw 2017/03/16 22:50:39 optional nit: // This structure matches ui::Accele optional nit: // This structure matches ui::Accelerator; see details there. (James has actually been encouraging me to document mojoms equally or better than the corresponding types in our c++ headers) sky 2017/03/16 23:30:46 Done. Show quoted text On 2017/03/16 22:50:39, msw wrote: > optional nit: // This structure matches ui::Accelerator; see details there. > (James has actually been encouraging me to document mojoms equally or better > than the corresponding types in our c++ headers) Done.
	16 struct Accelerator {

	17 // Accelerator::key_code_ is a KeyboardCode, but it may also contain other
	msw 2017/03/16 22:50:39 optional nit: It might help to elaborate on what o optional nit: It might help to elaborate on what other values it may contain. sky 2017/03/16 23:30:46 Done. Show quoted text On 2017/03/16 22:50:39, msw wrote: > optional nit: It might help to elaborate on what other values it may contain. Done.
	18 // values.

	19 int32 key_code;

	20 AcceleratorKeyState key_state;

	21 int32 modifiers;

	22 };

OLD	NEW

« ui/base/accelerators/mojo/BUILD.gn ('K') | « ui/base/accelerators/mojo/OWNERS ('k') | ui/base/accelerators/mojo/accelerator.typemap » ('j') | no next file with comments »