Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.idl

Issue 2749153005: Make CredentialsContainer#get argument options optional to match the spec (Closed)
Patch Set: Update credentialmanager/idl.html tests after the idl change Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.idl
diff --git a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.idl b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.idl
index 7e3cefe86d20755ef1bf0ad36fa71d57627be9e0..f96c6710fe43852c6a90aee20b9ef51954a4c14e 100644
--- a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.idl
+++ b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.idl
@@ -2,10 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+// https://w3c.github.io/webappsec-credential-management/#credentialscontainer
+
[
RuntimeEnabled=CredentialManager,
] interface CredentialsContainer {
- [CallWith=ScriptState, MeasureAs=CredentialManagerGet] Promise get(CredentialRequestOptions options);
+ [CallWith=ScriptState, MeasureAs=CredentialManagerGet] Promise get(optional CredentialRequestOptions options);
[CallWith=ScriptState, MeasureAs=CredentialManagerStore] Promise store(Credential credential);
[CallWith=ScriptState, MeasureAs=CredentialManagerRequireUserMediation] Promise requireUserMediation();
};
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698