third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html - Issue 2749153005: Make CredentialsContainer#get argument options optional to match the spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html

Issue 2749153005: Make CredentialsContainer#get argument options optional to match the spec (Closed)

Patch Set: Update credentialmanager/idl.html tests after the idl change Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html ('k') | third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html b/third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html

index 11073849f8135dbbe6c08b446f035ce37e96c9e1..8d110b27a854b392db408d9eeb758651f8bf12e0 100644

--- a/third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html

+++ b/third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html

@@ -50,7 +50,7 @@

</script>

interface CredentialsContainer {

- Promise<Credential?> get(CredentialRequestOptions options);

+ Promise<Credential> get(optional CredentialRequestOptions options);

Promise<Credential> store(Credential credential);

Promise<void> requireUserMediation();

};