Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Issue 2749073002: Reduce test runtimes for MSAN bots (Closed)

Created:
3 years, 9 months ago by Raymond Toy
Modified:
3 years, 9 months ago
Reviewers:
qyearsley, hongchan
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce test runtimes for MSAN bots Reduce the run time for some tests by reducing the render duration, sample rate or both. The thresholds for biquad-automation had to be adjusted slightly for the new duration (because the automations now end sooner.) On a Z620 machine running linux, the debug runtimes before: webaudio/AudioParam/audioparam-method-chaining.html took: 1.343 webaudio/BiquadFilter/biquad-automation.html took: 1.970 webaudio/IIRFilter/iirfilter.html took: 2.847 After: webaudio/AudioParam/audioparam-method-chaining.html took: 0.745 webaudio/BiquadFilter/biquad-automation.html took: 1.658 webaudio/IIRFilter/iirfilter.html took: 1.277 BUG=701418 TEST=AudioParam/audioparam-method-chaining.html, BiquadFilter/biquad-automation.html, IIRFilter/iirfilter.html Review-Url: https://codereview.chromium.org/2749073002 Cr-Commit-Position: refs/heads/master@{#456826} Committed: https://chromium.googlesource.com/chromium/src/+/9efae816aebf5f8547d75b667a39f73527346ba5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-method-chaining.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-automation.html View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Raymond Toy
PTAL. FYI qyearsley. Perhaps this will fix the flakiness?
3 years, 9 months ago (2017-03-14 18:42:57 UTC) #4
hongchan
lgtm
3 years, 9 months ago (2017-03-14 18:49:15 UTC) #5
qyearsley
lgtm too :-)
3 years, 9 months ago (2017-03-14 18:50:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749073002/1
3 years, 9 months ago (2017-03-14 20:48:32 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 21:04:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9efae816aebf5f8547d75b667a39...

Powered by Google App Engine
This is Rietveld 408576698