third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js - Issue 2749043005: [DevTools] Make NetworkLog a singleton, and not an SDKModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

Issue 2749043005: [DevTools] Make NetworkLog a singleton, and not an SDKModel (Closed)

Patch Set: review comments addressed Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js ('k') | third_party/WebKit/Source/devtools/front_end/main/Main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

diff --git a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

index cd4241b58bd6fe46286d7ea260e0082b19a9ffb2..663d8cee9a3f84ecf32f16c1e0bfd6238f8433c3 100644

--- a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

+++ b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

@@ -393,7 +393,7 @@ Extensions.ExtensionServer = class extends Common.Object {

return this._status.OK();

}

- var request = SDK.NetworkLog.requestForURL(message.url);

+ var request = SDK.networkLog.requestForURL(message.url);

if (request) {

Common.Revealer.reveal(request);

return this._status.OK();

@@ -449,7 +449,7 @@ Extensions.ExtensionServer = class extends Common.Object {

}

_onGetHAR() {

- var requests = SDK.NetworkLog.requests();

+ var requests = SDK.networkLog.requests();

var harLog = (new SDK.HARLog(requests)).build();

for (var i = 0; i < harLog.entries.length; ++i)

harLog.entries[i]._requestId = this._requestId(requests[i]);