third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js - Issue 2749043005: [DevTools] Make NetworkLog a singleton, and not an SDKModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js

Issue 2749043005: [DevTools] Make NetworkLog a singleton, and not an SDKModel (Closed)

Patch Set: review comments addressed Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/Linkifier.js ('k') | third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js b/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js

index fe95a26edad96c606d82eadd6389a36ca43b4f38..d371a50b508158127bacc6a52eba2b82d0ac124a 100644

--- a/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js

@@ -436,8 +436,7 @@ ConsoleModel.ConsoleMessage = class {

this.scriptId = scriptId || null;

this.workerId = workerId || null;

- var networkLog = target && SDK.NetworkLog.fromTarget(target);

- this.request = (requestId && networkLog) ? networkLog.requestForId(requestId) : null;

+ this.request = (target && requestId) ? SDK.networkLog.requestForId(target, requestId) : null;

if (this.request) {

var initiator = this.request.initiator();