Clang plugin: Support for Blink in web/.

tools/clang/plugins/ChromeClassTester.cpp

Index: tools/clang/plugins/ChromeClassTester.cpp
diff --git a/tools/clang/plugins/ChromeClassTester.cpp b/tools/clang/plugins/ChromeClassTester.cpp
index c9388067234f44a1985587dd660edfd1417b1e1c..1cc84a843c62ca5351a46002ebcb7d85632d4a9d 100644
--- a/tools/clang/plugins/ChromeClassTester.cpp
+++ b/tools/clang/plugins/ChromeClassTester.cpp
@@ -234,6 +234,7 @@ void ChromeClassTester::BuildBannedLists() {
   banned_namespaces_.emplace("__gnu_cxx");
 
   blink_directories_.emplace("/third_party/WebKit/");
+  blink_directories_.emplace("/web/");

[dcheng, 2017/04/12 23:35:27]

Is it possible that this will cause us to match things that it shouldn't? For
instance, we have files in the /web/ directory in the gen files directory:
https://cs.chromium.org/search/?q=file:/gen/+file:/web/+package:%5Echromium$&...

[tkent, 2017/04/13 00:18:00]

Oh, it's possible.  I also found src/ios/web/, which should not be
LocationType::kBlink.
Is there a way to get Chromium repository root in
ChromeClassTester::ClassifyLocation()?

[tkent, 2017/04/13 00:32:38]

I think switching behavior by a plugin argument is more flexible.
   e.g. -Xclang -plugin-arg-find-bad-constructs -Xclang check-for-blink
What do you think?

 
   banned_directories_.emplace("/third_party/");
   banned_directories_.emplace("/native_client/");