Clang plugin: Support for Blink in web/.

tools/clang/plugins/ChromeClassTester.cpp

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A general interface for filtering and only acting on classes in Chromium C++
 // code.
 
 #include "ChromeClassTester.h"
 
 #include <algorithm>
@@ skipping 216 matching lines @@
   }
 
   return false;
 }
 
 void ChromeClassTester::BuildBannedLists() {
   banned_namespaces_.emplace("std");
   banned_namespaces_.emplace("__gnu_cxx");
 
   blink_directories_.emplace("/third_party/WebKit/");
+  blink_directories_.emplace("/web/");

[dcheng, 2017/04/12 23:35:27]

Is it possible that this will cause us to match things that it shouldn't? For
instance, we have files in the /web/ directory in the gen files directory:
https://cs.chromium.org/search/?q=file:/gen/+file:/web/+package:%5Echromium$&...

[tkent, 2017/04/13 00:18:00]

Oh, it's possible.  I also found src/ios/web/, which should not be
LocationType::kBlink.
Is there a way to get Chromium repository root in
ChromeClassTester::ClassifyLocation()?

[tkent, 2017/04/13 00:32:38]

I think switching behavior by a plugin argument is more flexible.
   e.g. -Xclang -plugin-arg-find-bad-constructs -Xclang check-for-blink
What do you think?

 
   banned_directories_.emplace("/third_party/");
   banned_directories_.emplace("/native_client/");
   banned_directories_.emplace("/breakpad/");
   banned_directories_.emplace("/courgette/");
   banned_directories_.emplace("/ppapi/");
   banned_directories_.emplace("/testing/");
   banned_directories_.emplace("/v8/");
   banned_directories_.emplace("/sdch/");
   banned_directories_.emplace("/frameworks/");
@@ skipping 87 matching lines @@
   }
 
   *filename = ploc.getFilename();
   return true;
 }
 
 DiagnosticsEngine::Level ChromeClassTester::getErrorLevel() {
   return diagnostic().getWarningsAsErrors() ? DiagnosticsEngine::Error
                                             : DiagnosticsEngine::Warning;
 }