Moved tests from DataManager to JobData.

Moved tests from DataManager to JobData.

Originally, the request management was in the BackgroundFetchDataManager,
but it was moved into the JobData and the tests weren't moved at the same
time. This CL moves those tests, which avoids a lot of setup for the
unused DataManager functionality.

This also expands the testing for the JobData, adding tests for paused,
cancelled, and out of order request completion.

BUG=692544
Review-Url: https://codereview.chromium.org/2749043003
Cr-Commit-Position: refs/heads/master@{#458401}
Committed: https://chromium.googlesource.com/chromium/src/+/85aa3feee7879a190e2a9a9563e1e3daf59676f1

[harkness, 2017-03-15 16:19:56]

harkness@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2017-03-16 12:43:50]

lgtm

https://codereview.chromium.org/2749043003/diff/20001/content/browser/backgro...
File content/browser/background_fetch/background_fetch_job_data_unittest.cc
(right):

https://codereview.chromium.org/2749043003/diff/20001/content/browser/backgro...
content/browser/background_fetch/background_fetch_job_data_unittest.cc:19: }  //
namespace
nit: you can put this in the `content` namespace, which is more common -

    namespace content {
    namespace {
    // ...
    }  // namespace
    // ...
    }  // namespace content

https://codereview.chromium.org/2749043003/diff/20001/content/browser/backgro...
content/browser/background_fetch/background_fetch_job_data_unittest.cc:25:
BackgroundFetchJobDataTest() {}
= default; (or delete if we can)

https://codereview.chromium.org/2749043003/diff/20001/content/browser/backgro...
content/browser/background_fetch/background_fetch_job_data_unittest.cc:35:
BackgroundFetchJobData* CreateSmallJobData() {
optional: Seems like it'd be nicer to just return a std::unique_ptr<> here.

https://codereview.chromium.org/2749043003/diff/20001/content/browser/backgro...
content/browser/background_fetch/background_fetch_job_data_unittest.cc:57:
BackgroundFetchJobDataTest::request_infos();
Here and elsewhere - drop the `BackgroundFetchJobDataTest` qualifier. That's a
parent class of this test.

[harkness, 2017-03-19 18:20:45]

https://codereview.chromium.org/2749043003/diff/20001/content/browser/backgro...
File content/browser/background_fetch/background_fetch_job_data_unittest.cc
(right):

https://codereview.chromium.org/2749043003/diff/20001/content/browser/backgro...
content/browser/background_fetch/background_fetch_job_data_unittest.cc:19: }  //
namespace
On 2017/03/16 12:43:50, Peter Beverloo wrote:
> nit: you can put this in the `content` namespace, which is more common -
> 
>     namespace content {
>     namespace {
>     // ...
>     }  // namespace
>     // ...
>     }  // namespace content

Done.

https://codereview.chromium.org/2749043003/diff/20001/content/browser/backgro...
content/browser/background_fetch/background_fetch_job_data_unittest.cc:25:
BackgroundFetchJobDataTest() {}
On 2017/03/16 12:43:50, Peter Beverloo wrote:
> = default; (or delete if we can)

Done.

https://codereview.chromium.org/2749043003/diff/20001/content/browser/backgro...
content/browser/background_fetch/background_fetch_job_data_unittest.cc:35:
BackgroundFetchJobData* CreateSmallJobData() {
On 2017/03/16 12:43:50, Peter Beverloo wrote:
> optional: Seems like it'd be nicer to just return a std::unique_ptr<> here.

Done.

https://codereview.chromium.org/2749043003/diff/20001/content/browser/backgro...
content/browser/background_fetch/background_fetch_job_data_unittest.cc:57:
BackgroundFetchJobDataTest::request_infos();
On 2017/03/16 12:43:50, Peter Beverloo wrote:
> Here and elsewhere - drop the `BackgroundFetchJobDataTest` qualifier. That's a
> parent class of this test.

Unfortunately it's here because of a clash in the naming. I really tried to
think of any other name than background_fetch_request_infos that I could use,
but given the choice of using that name or explicitly qualifying the function I
went with the BackgroundFetchJobDataTest:: qualifier.

[harkness, 2017-03-20 13:19:12]

The CQ bit was checked by harkness@chromium.org

[harkness, 2017-03-20 13:19:12]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2749043003/#ps60001
(title: "addressed code review comments")

[commit-bot: I haz the power, 2017-03-20 13:19:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 13:21:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 13:21:35]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[harkness, 2017-03-20 18:29:10]

The CQ bit was checked by harkness@chromium.org

[harkness, 2017-03-20 18:29:10]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2749043003/#ps100001
(title: "Fix rebase")

[commit-bot: I haz the power, 2017-03-20 18:30:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 19:19:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 19:19:29]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[harkness, 2017-03-21 12:00:45]

The CQ bit was checked by harkness@chromium.org

[harkness, 2017-03-21 12:00:45]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2749043003/#ps120001
(title: "Another rebase")

[commit-bot: I haz the power, 2017-03-21 12:00:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 12:46:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 12:46:36]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[harkness, 2017-03-21 13:52:55]

The CQ bit was checked by harkness@chromium.org

[commit-bot: I haz the power, 2017-03-21 13:53:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 14:19:07]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1490104375313680,
"parent_rev": "9252579e4ab9a83ff8a863288bf554aa82877585", "commit_rev":
"85aa3feee7879a190e2a9a9563e1e3daf59676f1"}

[commit-bot: I haz the power, 2017-03-21 14:19:48]

Description was changed from

==========
Moved tests from DataManager to JobData.

Originally, the request management was in the BackgroundFetchDataManager,
but it was moved into the JobData and the tests weren't moved at the same
time. This CL moves those tests, which avoids a lot of setup for the
unused DataManager functionality.

This also expands the testing for the JobData, adding tests for paused,
cancelled, and out of order request completion.

BUG=692544
==========

to

==========
Moved tests from DataManager to JobData.

Originally, the request management was in the BackgroundFetchDataManager,
but it was moved into the JobData and the tests weren't moved at the same
time. This CL moves those tests, which avoids a lot of setup for the
unused DataManager functionality.

This also expands the testing for the JobData, adding tests for paused,
cancelled, and out of order request completion.

BUG=692544

Review-Url: https://codereview.chromium.org/2749043003
Cr-Commit-Position: refs/heads/master@{#458401}
Committed:
https://chromium.googlesource.com/chromium/src/+/85aa3feee7879a190e2a9a9563e1...
==========

[commit-bot: I haz the power, 2017-03-21 14:19:49]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/85aa3feee7879a190e2a9a9563e1...