Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2749033002: In make_hfs.sh, explicitly mount the new volume. (Closed)

Created:
3 years, 9 months ago by Robert Sesek
Modified:
3 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In make_hfs.sh, explicitly mount the new volume. This should happen automatically after erasedisk, but perhaps it's not completing synchronously. BUG=696529 R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2749033002 Cr-Commit-Position: refs/heads/master@{#456775} Committed: https://chromium.googlesource.com/chromium/src/+/575512843787644524196d04076a59ec9415cb89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/test/data/safe_browsing/dmg/make_hfs.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Robert Sesek
3 years, 9 months ago (2017-03-14 17:07:04 UTC) #1
Nico
lgtm
3 years, 9 months ago (2017-03-14 17:10:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749033002/1
3 years, 9 months ago (2017-03-14 17:11:00 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 18:51:59 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/575512843787644524196d04076a...

Powered by Google App Engine
This is Rietveld 408576698