[MD settings] edit content settings exceptions

chrome/browser/resources/settings/site_settings/site_list.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Enumeration mapping all possible controlled-by values for exceptions to
  * icons.
  * @enum {string}
  */
 var iconControlledBy = {
@@ skipping 373 matching lines @@
    * @private
    */
   setUpActionMenu_: function() {
     this.showAllowAction_ =
         this.categorySubtype != settings.PermissionValues.ALLOW;
     this.showBlockAction_ =
         this.categorySubtype != settings.PermissionValues.BLOCK;
     this.showSessionOnlyAction_ =
         this.categorySubtype != settings.PermissionValues.SESSION_ONLY &&
         this.category == settings.ContentSettingsTypes.COOKIES;
+    /* Note: the following types are intentinally omitted: CAMERA, GEOLOCATION,
+     * MIC, MIDI_DEVICES, PROTECTED_CONTENT, PROTOCOL_HANDLERS, USB_DEVICES,
+     * ZOOM_LEVELS. */
     this.showEditAction_ =
-        this.category == settings.ContentSettingsTypes.COOKIES;
+        this.category == settings.ContentSettingsTypes.AUTOMATIC_DOWNLOADS ||
+        this.category == settings.ContentSettingsTypes.BACKGROUND_SYNC ||
+        this.category == settings.ContentSettingsTypes.COOKIES ||
+        this.category == settings.ContentSettingsTypes.IMAGES ||
+        this.category == settings.ContentSettingsTypes.JAVASCRIPT ||
+        this.category == settings.ContentSettingsTypes.NOTIFICATIONS ||
+        this.category == settings.ContentSettingsTypes.PLUGINS ||
+        this.category == settings.ContentSettingsTypes.POPUPS ||
+        this.category == settings.ContentSettingsTypes.UNSANDBOXED_PLUGINS;

[dschuyler, 2017/03/18 00:36:11]

Hmm, I could convert this to a dictionary and to a single map lookup, but I'm
concerned for the startup performance cost if I made that outside of this
function -- and it would be a wash if the map were set up right here.

I'd rather make this data driven in the html. I'll look into that.

   },
 
   /**
    * @return {boolean} Whether to show the "Session Only" menu item for the
    *     currently active site.
    * @private
    */
   showSessionOnlyActionForSite_: function() {
     // It makes no sense to show "clear on exit" for exceptions that only apply
     // to incognito. It gives the impression that they might under some
@@ skipping 106 matching lines @@
 
   /** @private */
   closeActionMenu_: function() {
     this.actionMenuSite_ = null;
     var actionMenu = /** @type {!CrActionMenuElement} */ (
         this.$$('dialog[is=cr-action-menu]'));
     if (actionMenu.open)
       actionMenu.close();
   },
 });