Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4486)

Unified Diff: chrome/browser/resources/settings/site_settings/site_list.js

Issue 2749023008: [MD settings] edit content settings exceptions (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/site_list.js
diff --git a/chrome/browser/resources/settings/site_settings/site_list.js b/chrome/browser/resources/settings/site_settings/site_list.js
index ddfe126cdc39b67ca6031d504ffb471c3b4fa723..f692d1adf0f03a4ff60bf20cad737e427a4483a0 100644
--- a/chrome/browser/resources/settings/site_settings/site_list.js
+++ b/chrome/browser/resources/settings/site_settings/site_list.js
@@ -391,8 +391,19 @@ Polymer({
this.showSessionOnlyAction_ =
this.categorySubtype != settings.PermissionValues.SESSION_ONLY &&
this.category == settings.ContentSettingsTypes.COOKIES;
+ /* Note: the following types are intentinally omitted: CAMERA, GEOLOCATION,
+ * MIC, MIDI_DEVICES, PROTECTED_CONTENT, PROTOCOL_HANDLERS, USB_DEVICES,
+ * ZOOM_LEVELS. */
this.showEditAction_ =
- this.category == settings.ContentSettingsTypes.COOKIES;
+ this.category == settings.ContentSettingsTypes.AUTOMATIC_DOWNLOADS ||
+ this.category == settings.ContentSettingsTypes.BACKGROUND_SYNC ||
+ this.category == settings.ContentSettingsTypes.COOKIES ||
+ this.category == settings.ContentSettingsTypes.IMAGES ||
+ this.category == settings.ContentSettingsTypes.JAVASCRIPT ||
+ this.category == settings.ContentSettingsTypes.NOTIFICATIONS ||
+ this.category == settings.ContentSettingsTypes.PLUGINS ||
+ this.category == settings.ContentSettingsTypes.POPUPS ||
+ this.category == settings.ContentSettingsTypes.UNSANDBOXED_PLUGINS;
dschuyler 2017/03/18 00:36:11 Hmm, I could convert this to a dictionary and to a
},
/**

Powered by Google App Engine
This is Rietveld 408576698