Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 2748993003: -webkit-box-ordinal-group cannot exceed the keyspace for a HashSet (Closed)

Created:
3 years, 9 months ago by rhogan
Modified:
3 years, 9 months ago
Reviewers:
pilgrim_google, eae
CC:
blink-reviews, blink-reviews-style_chromium.org, cbiesinger, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

-webkit-box-ordinal-group cannot exceed the keyspace for a HashSet HashTables have the capacity of a 32bit int so anything greater than or equal std::numeric_limits<unsigned>::max() will just overflow to -1 or reference an unavailable bucket, so cap it to max() - 1. BUG=700622 Review-Url: https://codereview.chromium.org/2748993003 Cr-Commit-Position: refs/heads/master@{#457981} Committed: https://chromium.googlesource.com/chromium/src/+/16b1ddb99276778202afb33e762c7d422118f374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/deprecated-flexbox/ordinal-group-max-value.html View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/deprecated-flexbox/ordinal-group-max-value-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
rhogan
3 years, 9 months ago (2017-03-15 17:08:09 UTC) #6
eae
LGTM
3 years, 9 months ago (2017-03-18 20:13:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748993003/1
3 years, 9 months ago (2017-03-18 20:13:50 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-18 21:59:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/16b1ddb99276778202afb33e762c...

Powered by Google App Engine
This is Rietveld 408576698