third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item.html - Issue 2748983003: [css-grid] Fix crash removing positioned grid item

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item.html

Issue 2748983003: [css-grid] Fix crash removing positioned grid item (Closed)

Patch Set: Early return, improved test and more comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item.html

diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item.html

new file mode 100644

index 0000000000000000000000000000000000000000..c5afdf0980d9fdb99b4b196cee1e678129adc29d

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item.html

@@ -0,0 +1,21 @@

+<!DOCTYPE html>

+<script>

+ if (window.testRunner)

+ testRunner.dumpAsText();

+</script>

+<p>crbug.com/700383 - [css-grid] Grid layouts go mostly blank</p>

+<p>This test has PASSED if it does not CRASH on debug.</p>

+<div id="grid" style="display: grid;">

+ <!-- This grid item with some text is needed,

+ otherwise LayoutGrid::paintChildren() won't be called

+ after removing the positioned item. -->

+ <div>item</div>

+</div>

+<script>

+ var abspositem = document.createElement("div");

+ abspositem.style.position = "absolute";

+ var grid = document.getElementById("grid");

+ grid.appendChild(abspositem);

+ document.body.offsetLeft;

+ grid.removeChild(abspositem);

+</script>

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-crash-remove-positioned-item-expected.txt » ('j') | no next file with comments »