Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2748983002: Make window resizing animation of share dialog faster to mitigate UI glitch. (Closed)

Created:
3 years, 9 months ago by yamaguchi
Modified:
3 years, 8 months ago
Reviewers:
fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make window resizing animation of share dialog faster to mitigate UI glitch. This is a quick fix for mitigating the slow loading of the error message. The share dialog will show resizing animation when the inner content size changes, however, the inner content is not aligned to the container while transition is ongoing. This change mitigates that bad effect by shortening the animation time, as well as shortening the delay after animation finished. TEST=manually tested as noted in the bug. BUG=701282 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2748983002 Cr-Commit-Position: refs/heads/master@{#460305} Committed: https://chromium.googlesource.com/chromium/src/+/9d2c054aa276113ab85d0493b58d1f33250df1e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/file_manager/file_manager/foreground/css/share_dialog.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/share_dialog.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
yamaguchi
ptal
3 years, 9 months ago (2017-03-14 14:12:13 UTC) #4
fukino
lgtm
3 years, 9 months ago (2017-03-22 01:09:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748983002/1
3 years, 9 months ago (2017-03-22 01:11:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 9 months ago (2017-03-22 03:13:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748983002/1
3 years, 9 months ago (2017-03-22 03:41:53 UTC) #13
commit-bot: I haz the power
Exceeded global retry quota
3 years, 9 months ago (2017-03-22 06:02:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748983002/1
3 years, 8 months ago (2017-03-29 05:34:48 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 06:50:47 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d2c054aa276113ab85d0493b58d...

Powered by Google App Engine
This is Rietveld 408576698