Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 2748973004: LogDog: index.html determines app parameters. (Closed)

Created:
3 years, 9 months ago by dnj
Modified:
3 years, 9 months ago
Reviewers:
nodir, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

LogDog: index.html determines app parameters. Load app parameters in "index.html", rather than indirectly through a linked script. Using the linked script introduced a load race condition that was notable on Safari. BUG=chromium:701488 TEST=local - Tested locally in Chrome and Safari. Review-Url: https://codereview.chromium.org/2748973004 Committed: https://github.com/luci/luci-go/commit/d11c001579e3145d6431fcf80f4985623b3bfee7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -23 lines) Patch
M web/apps/logdog-app/index.html View 2 chunks +6 lines, -6 lines 0 comments Download
M web/apps/logdog-view/index.html View 2 chunks +6 lines, -5 lines 0 comments Download
M web/inc/logdog-app-base/logdog-app-base.html View 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dnj
PTAL!
3 years, 9 months ago (2017-03-14 22:05:08 UTC) #2
hinoka
lgtm
3 years, 9 months ago (2017-03-14 22:12:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748973004/1
3 years, 9 months ago (2017-03-14 22:13:08 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 22:19:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/d11c001579e3145d6431fcf80f4985623b3bfee7

Powered by Google App Engine
This is Rietveld 408576698