Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2748963002: Remove old flow-thread aware code from computeLogicalLocationForFloat(). (Closed)

Created:
3 years, 9 months ago by mstensho (USE GERRIT)
Modified:
3 years, 9 months ago
Reviewers:
eae
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove old flow-thread aware code from computeLogicalLocationForFloat(). CSS regions supported variable fragmentainer widths. However, multicol doesn't, so the code is no longer necessary. Review-Url: https://codereview.chromium.org/2748963002 Cr-Commit-Position: refs/heads/master@{#457149} Committed: https://chromium.googlesource.com/chromium/src/+/b2e8c35d8bde821a28d0a648d75998efed7ad1c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 3 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mstensho (USE GERRIT)
3 years, 9 months ago (2017-03-14 11:25:56 UTC) #6
eae
Yay, LGTM
3 years, 9 months ago (2017-03-15 17:04:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748963002/1
3 years, 9 months ago (2017-03-15 17:05:06 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 18:34:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b2e8c35d8bde821a28d0a648d759...

Powered by Google App Engine
This is Rietveld 408576698