Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2748953002: Remove createSameThreadTask() and deprecate createCrossThreadTask() (Closed)

Created:
3 years, 9 months ago by yuryu
Modified:
3 years, 9 months ago
Reviewers:
haraken, nhiroki, tzik
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, eae+blinkwatch, yzshen+watch_chromium.org, kinuko+worker_chromium.org, Srirama, kinuko+watch, rwlbuis, tzik, abarth-chromium, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, falken+watch_chromium.org, blink-worker-reviews_chromium.org, sof, nhiroki, feature-media-reviews_chromium.org, eric.carlson_apple.com, mlamouri+watch-blink_chromium.org, shimazu+worker_chromium.org, Aaron Boodman, horo+watch_chromium.org, darin (slow to review), kinuko+fileapi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove createSameThreadTask() and deprecate createCrossThreadTask() These functions and ExecutionContextTask are deprecated in favor of WTF::bind(), crossThreadBind(), and WTF::Closure and WTF::CrossThreadClosure respectively. This patch removes createSameThreadTask() and mark createCrossThreadTask() deprecated. It also removes unused ExecutionContextTask.h includes. BUG=625927 Review-Url: https://codereview.chromium.org/2748953002 Cr-Commit-Position: refs/heads/master@{#456651} Committed: https://chromium.googlesource.com/chromium/src/+/cd45ce00fc6cf88a65b370c1a574e5b26319a40b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -21 lines) Patch
M third_party/WebKit/Source/core/dom/ExecutionContextTask.h View 1 chunk +9 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/mojo/MojoWatcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
yuryu
ptal, thanks
3 years, 9 months ago (2017-03-14 04:39:07 UTC) #4
nhiroki
LGTM! :D
3 years, 9 months ago (2017-03-14 05:25:51 UTC) #5
haraken
LGTM
3 years, 9 months ago (2017-03-14 07:59:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748953002/1
3 years, 9 months ago (2017-03-14 08:20:10 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 08:26:09 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cd45ce00fc6cf88a65b370c1a574...

Powered by Google App Engine
This is Rietveld 408576698