Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2748923002: Remove dead splice_timestamp() field from DecoderBuffer. (Closed)

Created:
3 years, 9 months ago by DaleCurtis
Modified:
3 years, 9 months ago
Reviewers:
chcunningham, miu, dcheng
CC:
Aaron Boodman, abarth-chromium, alokp+watch_chromium.org, apacible+watch_chromium.org, chromium-reviews, darin (slow to review), erickung+watch_chromium.org, feature-media-reviews_chromium.org, miu+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, xjz+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead splice_timestamp() field from DecoderBuffer. This died in 8ae8c69e525729f91c22544659705689765ef58a when we replaced splicing with trimming via discard padding. BUG=588351, 577438 TEST=compile Review-Url: https://codereview.chromium.org/2748923002 Cr-Commit-Position: refs/heads/master@{#456992} Committed: https://chromium.googlesource.com/chromium/src/+/c4e4055ac82f567de79d7ed94060036dbecda2d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -33 lines) Patch
M media/base/decoder_buffer.h View 2 chunks +0 lines, -15 lines 0 comments Download
M media/base/decoder_buffer.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/mojo/common/media_type_converters.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/mojo/common/media_type_converters_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/mojo/common/mojo_decoder_buffer_converter_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/mojo/interfaces/media_types.mojom View 1 chunk +0 lines, -3 lines 0 comments Download
M media/remoting/proto_utils.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M media/remoting/rpc.proto View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
DaleCurtis
+miu for media/remoting proto changes (I think I did it right?) +dcheng for mojom changes ...
3 years, 9 months ago (2017-03-13 23:45:31 UTC) #2
dcheng
rs lgtm for deletions in mojom
3 years, 9 months ago (2017-03-13 23:48:01 UTC) #3
chcunningham
lgtm.
3 years, 9 months ago (2017-03-14 00:01:59 UTC) #4
miu
lgtm
3 years, 9 months ago (2017-03-14 23:18:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748923002/1
3 years, 9 months ago (2017-03-15 02:50:19 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 04:27:32 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c4e4055ac82f567de79d7ed94060...

Powered by Google App Engine
This is Rietveld 408576698