Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2748913002: [Merge to M58] [Android Crash Reporting] Simplify crash report upload code. (Closed)

Created:
3 years, 9 months ago by Ilya Sherman
Modified:
3 years, 9 months ago
Reviewers:
Maria
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge to M58] [Android Crash Reporting] Simplify crash report upload code. In particular: run the code to extract logcat output within the context of the main Chrome process/service, rather than kicking off the work to a pair of background services. Moreover, dramatically simplify the MetricsUploadService code: remove all but one of the intents that it handles. BUG=694884 R=mariakhomenko@chromium.org Review-Url: https://codereview.chromium.org/2727573004 Cr-Commit-Position: refs/heads/master@{#455704} (cherry picked from commit a9a8f4e062bd1c72c3b511de3c41611e24b7949e) Review-Url: https://codereview.chromium.org/2748913002 . Cr-Commit-Position: refs/branch-heads/3029@{#172} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/02cb7c80b97142fa5b34abea202b7755dcf9e476

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+533 lines, -1575 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java View 7 chunks +113 lines, -18 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionCallable.java View 1 chunk +0 lines, -421 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnable.java View 6 chunks +33 lines, -119 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionService.java View 1 chunk +0 lines, -68 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java View 1 chunk +19 lines, -24 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpLogcatPrepender.java View 1 chunk +165 lines, -0 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpPreparationCallable.java View 1 chunk +0 lines, -197 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpPreparationService.java View 1 chunk +0 lines, -72 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java View 7 chunks +34 lines, -141 lines 0 comments Download
M chrome/android/java_sources.gni View 3 chunks +4 lines, -6 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java View 1 chunk +0 lines, -98 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnableTest.java View 1 chunk +111 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java View 11 chunks +10 lines, -159 lines 0 comments Download
D chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableUnitTest.java View 1 chunk +0 lines, -221 lines 0 comments Download
A + chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnableUnitTest.java View 3 chunks +21 lines, -21 lines 0 comments Download
M components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java View 2 chunks +0 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Ilya Sherman
3 years, 9 months ago (2017-03-13 23:08:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
02cb7c80b97142fa5b34abea202b7755dcf9e476.

Powered by Google App Engine
This is Rietveld 408576698