Added unit tests for switch_access.js.

Added unit tests for switch_access.js.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2748853002
Cr-Commit-Position: refs/heads/master@{#456943}
Committed: https://chromium.googlesource.com/chromium/src/+/0b2807a74e0055362506beb0cda0b8f3c9d0cd40

[elichtenberg, 2017-03-13 21:51:43]

Description was changed from

==========
Added unit tests for switch_access.js.

BUG=593885
==========

to

==========
Added unit tests for switch_access.js.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[elichtenberg, 2017-03-13 21:52:32]

The CQ bit was checked by elichtenberg@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 21:53:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[elichtenberg, 2017-03-13 21:53:58]

elichtenberg@google.com changed reviewers:
+ dmazzoni@chromium.org, dtseng@chromium.org

[commit-bot: I haz the power, 2017-03-13 23:18:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 23:18:56]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-03-14 16:08:49]

lgtm, just some suggestions

https://codereview.chromium.org/2748853002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/switch_access/switch_access_unittest.gtestjs
(right):

https://codereview.chromium.org/2748853002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/switch_access/switch_access_unittest.gtestjs:24:
getSampleTree: function() {
To make it easier to understand, I recommend a bit of indented
ASCII art at the top, like this:

// root
//   middle1
//     leaf1
//     leaf2
//     leaf3
//   middle2
//     leaf4
//     leaf5

https://codereview.chromium.org/2748853002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/switch_access/switch_access_unittest.gtestjs:76:
assertTrue(tsa.getNextNode(tree.root) === tree.middle1);
An alternative idea for readability:

var inOrder = [];
var node = tree.root;
while (node) {
  inOrder.push(node);
  node = tsa.getNextNode(node);
}

assert_equals(inOrder, [
  root, middle1, leaf1, leaf2, ... ]);

[elichtenberg, 2017-03-14 17:36:49]

https://codereview.chromium.org/2748853002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/switch_access/switch_access_unittest.gtestjs
(right):

https://codereview.chromium.org/2748853002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/switch_access/switch_access_unittest.gtestjs:24:
getSampleTree: function() {
On 2017/03/14 16:08:49, dmazzoni wrote:
> To make it easier to understand, I recommend a bit of indented
> ASCII art at the top, like this:
> 
> // root
> //   middle1
> //     leaf1
> //     leaf2
> //     leaf3
> //   middle2
> //     leaf4
> //     leaf5

Done. Do I need an extra line above the comment, or is this good?

https://codereview.chromium.org/2748853002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/switch_access/switch_access_unittest.gtestjs:76:
assertTrue(tsa.getNextNode(tree.root) === tree.middle1);
On 2017/03/14 16:08:49, dmazzoni wrote:
> An alternative idea for readability:
> 
> var inOrder = [];
> var node = tree.root;
> while (node) {
>   inOrder.push(node);
>   node = tsa.getNextNode(node);
> }
> 
> assert_equals(inOrder, [
>   root, middle1, leaf1, leaf2, ... ]);
> 

Done. Did it slightly differently but with the same idea.

[elichtenberg, 2017-03-14 22:19:27]

The CQ bit was checked by elichtenberg@google.com

[elichtenberg, 2017-03-14 22:19:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2748853002/#ps20001
(title: "Responded to comments")

[commit-bot: I haz the power, 2017-03-14 22:20:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 01:57:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489529967534500,
"parent_rev": "7005dc9fffe6f00c583033892ef07779793834d2", "commit_rev":
"0b2807a74e0055362506beb0cda0b8f3c9d0cd40"}

[commit-bot: I haz the power, 2017-03-15 01:58:18]

Description was changed from

==========
Added unit tests for switch_access.js.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Added unit tests for switch_access.js.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2748853002
Cr-Commit-Position: refs/heads/master@{#456943}
Committed:
https://chromium.googlesource.com/chromium/src/+/0b2807a74e0055362506beb0cda0...
==========

[commit-bot: I haz the power, 2017-03-15 01:58:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0b2807a74e0055362506beb0cda0...