Fix the position of show result category checkbox for easy access.

Fix the position of show result category checkbox for easy access.

The option for showing category results {expected failues, flaky failures
unexpected passes & stderr} is placed at the bottom of page and is not fixed.
When the result of any category (above mentioned) is more than screen length,
we have to scroll to the end of page to change it again, which seems wrong ui.
We should have it placed along with other option (like toggle images), so that
we can change it without scrolling the page.

BUG=None

TEST=None; no behavior change;

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159986

[r.kasibhatla, 2013-10-16 08:42:22]

PTAL.

[Dirk Pranke, 2013-10-16 19:27:58]

I like the idea of moving the checkboxes to the top. I defer to Ojan as to
whether the change is the best way to do that. He might also have a good reason
for not putting the checkboxes at the top.

[ojan, 2013-10-16 23:05:19]

https://codereview.chromium.org/27488002/diff/1/LayoutTests/fast/harness/resu...
File LayoutTests/fast/harness/results.html (right):

https://codereview.chromium.org/27488002/diff/1/LayoutTests/fast/harness/resu...
LayoutTests/fast/harness/results.html:96: top: 50%;
This doesn't look right to me. What effect are you trying for here? A screenshot
might help me understand.

[r.kasibhatla, 2013-10-17 04:03:24]

I have reworked to simply the changes. I have now moved all the 4
labels+checkboxes inside #toolbar div itself and creating no new div elements.
Also, just to align all elements within the width of first line (the message at
top of #toolbar), I have split the checkboxes across 2 lines. Otherwise, it was
overlapping on top of results (though its trasparent, thought it might be best
to keep within limits to avoid overlap).
PTAL.

https://codereview.chromium.org/27488002/diff/1/LayoutTests/fast/harness/resu...
File LayoutTests/fast/harness/results.html (right):

https://codereview.chromium.org/27488002/diff/1/LayoutTests/fast/harness/resu...
LayoutTests/fast/harness/results.html:96: top: 50%;
On 2013/10/16 23:05:19, ojan wrote:
> This doesn't look right to me. What effect are you trying for here? A
screenshot
> might help me understand.
Originally, I created 2 div blocks (containing the labels) which were placed
inside another fixed position (#container) div. My intention here was to give
50% space for each div inside container. I realized it was not neccessary and
just complicating things. I have removed this in new patch.

[ojan, 2013-10-17 20:30:48]

I find all the checkboxes a bit overwhelming. Can you change it so that they're
all in the same line (i.e. wrapped in a container div) and remove the duplicated
"Show"?

e.g. soemthing like

<div id="show-container">
    Show: 
    <label><input id="show-expected-failures" type=checkbox
onchange="handleUnexpectedResultsChange()">expected failures</label>
    <label><input id="show-flaky-failures" type=checkbox
onchange="handleFlakyFailuresChange()">flaky failures</label>
    etc.
</div>

[r.kasibhatla, 2013-10-18 03:41:38]

On 2013/10/17 20:30:48, ojan wrote:
> I find all the checkboxes a bit overwhelming. Can you change it so that
they're
> all in the same line (i.e. wrapped in a container div) and remove the
duplicated
> "Show"?
> 
> e.g. soemthing like
> 
> <div id="show-container">
>     Show: 
>     <label><input id="show-expected-failures" type=checkbox
> onchange="handleUnexpectedResultsChange()">expected failures</label>
>     <label><input id="show-flaky-failures" type=checkbox
> onchange="handleFlakyFailuresChange()">flaky failures</label>
>     etc.
> </div>

Done.

[ojan, 2013-10-18 17:29:32]

lgtm

[commit-bot: I haz the power, 2013-10-18 18:06:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/27488002/41001

[commit-bot: I haz the power, 2013-10-19 01:08:18]

Change committed as 159986