Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: LayoutTests/fast/harness/results.html

Issue 27488002: Fix the position of show result category checkbox for easy access. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <style> 2 <style>
3 html { 3 html {
4 height: 100%; 4 height: 100%;
5 } 5 }
6 body { 6 body {
7 margin: 0; 7 margin: 0;
8 font-family: Helvetica, sans-serif; 8 font-family: Helvetica, sans-serif;
9 font-size: 11pt; 9 font-size: 11pt;
10 display: -webkit-flex; 10 display: -webkit-flex;
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 68
69 .results-row iframe, .results-row img { 69 .results-row iframe, .results-row img {
70 width: 800px; 70 width: 800px;
71 height: 600px; 71 height: 600px;
72 } 72 }
73 73
74 .results-row[data-expanded="false"] { 74 .results-row[data-expanded="false"] {
75 display: none; 75 display: none;
76 } 76 }
77 77
78 #toolbar { 78 #container {
79 position: fixed; 79 position: fixed;
80 padding: 4px; 80 padding: 4px;
81 top: 2px; 81 top: 2px;
82 right: 2px; 82 right: 2px;
83 text-align: right; 83 text-align: right;
84 background-color: rgba(255, 255, 255, 0.85); 84 background-color: rgba(255, 255, 255, 0.85);
85 border: 1px solid silver; 85 border: 1px solid silver;
86 border-radius: 4px; 86 border-radius: 4px;
87 } 87 }
88 88
89 #toolbar {
90 position: relative;
91 top: 0;
92 }
93
94 #resultbar {
95 position: relative;
96 top: 50%;
ojan 2013/10/16 23:05:19 This doesn't look right to me. What effect are you
r.kasibhatla 2013/10/17 04:03:24 Originally, I created 2 div blocks (containing the
97 }
98
89 .expand-button { 99 .expand-button {
90 background-color: white; 100 background-color: white;
91 width: 11px; 101 width: 11px;
92 height: 12px; 102 height: 12px;
93 border: 1px solid gray; 103 border: 1px solid gray;
94 display: inline-block; 104 display: inline-block;
95 margin: 0 3px 0 0; 105 margin: 0 3px 0 0;
96 position: relative; 106 position: relative;
97 cursor: default; 107 cursor: default;
98 } 108 }
(...skipping 1182 matching lines...) Expand 10 before | Expand all | Expand 10 after
1281 1291
1282 1292
1283 return header + tableRowHtml + '</table></div>'; 1293 return header + tableRowHtml + '</table></div>';
1284 } 1294 }
1285 1295
1286 1296
1287 function generatePage() 1297 function generatePage()
1288 { 1298 {
1289 forEachTest(processGlobalStateFor); 1299 forEachTest(processGlobalStateFor);
1290 1300
1291 var html = '<div class=content-container><div id=toolbar>' + 1301 var html = '<div class=content-container><div id=container><div id=toolbar>' +
1292 '<div class="note">Use the i, j, k and l keys to navigate, e, c to expan d and collapse, and f to flag</div>' + 1302 '<div class="note">Use the i, j, k and l keys to navigate, e, c to expan d and collapse, and f to flag</div>' +
1293 '<a href="javascript:void()" onclick="expandAllExpectations()">expand al l</a> ' + 1303 '<a href="javascript:void()" onclick="expandAllExpectations()">expand al l</a> ' +
1294 '<a href="javascript:void()" onclick="collapseAllExpectations()">collaps e all</a> ' + 1304 '<a href="javascript:void()" onclick="collapseAllExpectations()">collaps e all</a> ' +
1295 '<label><input id="toggle-images" type=checkbox checked onchange="handle ToggleImagesChange()">Toggle images</label>' + 1305 '<label><input id="toggle-images" type=checkbox checked onchange="handle ToggleImagesChange()">Toggle images</label>' +
1296 '</div>'; 1306 '</div><div id=resultbar>' +
1307 '<label><input id="show-expected-failures" type=checkbox onchange="h andleUnexpectedResultsChange()">Show expected failures</label>' +
1308 '<label><input id="show-flaky-failures" type=checkbox onchange="hand leFlakyFailuresChange()">Show flaky failures</label>' +
1309 '<label><input id="show-unexpected-passes" type=checkbox onchange="h andleUnexpectedPassesChange()">Show unexpected passes</label>' +
1310 '<label><input id="show-stderr" type=checkbox onchange="handleStderr Change()">Show stderr</label>' +
1311 '</div></div>';
1297 1312
1298 if (globalState().results.interrupted) 1313 if (globalState().results.interrupted)
1299 html += "<p class='stopped-running-early-message'>Testing exited early.< /p>" 1314 html += "<p class='stopped-running-early-message'>Testing exited early.< /p>"
1300 1315
1301 if (globalState().crashTests.length) 1316 if (globalState().crashTests.length)
1302 html += testList(globalState().crashTests, 'Tests that crashed', 'crash- tests-table'); 1317 html += testList(globalState().crashTests, 'Tests that crashed', 'crash- tests-table');
1303 1318
1304 html += failingTestsTable(globalState().failingTests, 1319 html += failingTestsTable(globalState().failingTests,
1305 'Tests that failed text/pixel/audio diff', 'results-table'); 1320 'Tests that failed text/pixel/audio diff', 'results-table');
1306 1321
(...skipping 10 matching lines...) Expand all
1317 'Flaky tests (failed the first run and passed on retry)', 'flaky-tests-t able'); 1332 'Flaky tests (failed the first run and passed on retry)', 'flaky-tests-t able');
1318 1333
1319 if (globalState().unexpectedPassTests.length) 1334 if (globalState().unexpectedPassTests.length)
1320 html += testList(globalState().unexpectedPassTests, 'Tests expected to f ail but passed', 'passes-table'); 1335 html += testList(globalState().unexpectedPassTests, 'Tests expected to f ail but passed', 'passes-table');
1321 1336
1322 if (globalState().hasHttpTests) { 1337 if (globalState().hasHttpTests) {
1323 html += '<p>httpd access log: <a href="access_log.txt">access_log.txt</a ></p>' + 1338 html += '<p>httpd access log: <a href="access_log.txt">access_log.txt</a ></p>' +
1324 '<p>httpd error log: <a href="error_log.txt">error_log.txt</a></p>'; 1339 '<p>httpd error log: <a href="error_log.txt">error_log.txt</a></p>';
1325 } 1340 }
1326 1341
1327 html += '</div><div>' + 1342 html += '</div>';
1328 '<label><input id="show-expected-failures" type=checkbox onchange="handl eUnexpectedResultsChange()">Show expected failures</label>' +
1329 '<label><input id="show-flaky-failures" type=checkbox onchange="handleFl akyFailuresChange()">Show flaky failures</label>' +
1330 '<label><input id="show-unexpected-passes" type=checkbox onchange="handl eUnexpectedPassesChange()">Show unexpected passes</label>' +
1331 '<label><input id="show-stderr" type=checkbox onchange="handleStderrChan ge()">Show stderr</label>' +
1332 '</div>';
1333 1343
1334 document.body.innerHTML = html; 1344 document.body.innerHTML = html;
1335 1345
1336 if (document.getElementById('results-table')) { 1346 if (document.getElementById('results-table')) {
1337 document.getElementById('results-table').addEventListener('click', Table Sorter.handleClick, false); 1347 document.getElementById('results-table').addEventListener('click', Table Sorter.handleClick, false);
1338 TableSorter.sortColumn(0); 1348 TableSorter.sortColumn(0);
1339 if (!globalState().hasTextFailures) 1349 if (!globalState().hasTextFailures)
1340 document.getElementById('text-results-header').textContent = ''; 1350 document.getElementById('text-results-header').textContent = '';
1341 if (!globalState().hasImageFailures) { 1351 if (!globalState().hasImageFailures) {
1342 document.getElementById('image-results-header').textContent = ''; 1352 document.getElementById('image-results-header').textContent = '';
1343 parentOfType(document.getElementById('toggle-images'), 'label').styl e.display = 'none'; 1353 parentOfType(document.getElementById('toggle-images'), 'label').styl e.display = 'none';
1344 } 1354 }
1345 } 1355 }
1346 1356
1347 updateTestlistCounts(); 1357 updateTestlistCounts();
1348 1358
1349 TestNavigator.reset(); 1359 TestNavigator.reset();
1350 OptionWriter.apply(); 1360 OptionWriter.apply();
1351 } 1361 }
1352 </script> 1362 </script>
1353 <!-- HACK: when json_results_test.js is included, loading this page runs the tes ts. 1363 <!-- HACK: when json_results_test.js is included, loading this page runs the tes ts.
1354 It is not copied to the layout-test-results output directory. --> 1364 It is not copied to the layout-test-results output directory. -->
1355 <script src="resources/results-test.js"></script> 1365 <script src="resources/results-test.js"></script>
1356 <body onload="generatePage()"></body> 1366 <body onload="generatePage()"></body>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698