[Payments] Remove toggle of Android payment apps in settings

Remove toggle of Android payment apps in settings

BUG=700480
Review-Url: https://codereview.chromium.org/2748793003
Cr-Commit-Position: refs/heads/master@{#456853}
Committed: https://chromium.googlesource.com/chromium/src/+/320588fcc48f1e0419ad64e36f55eb5f508c3298

[gogerald1, 2017-03-13 17:55:27]

Description was changed from

==========
Remove toggle of Android payment apps in settings


Remove toggle of Android payment apps in settings

BUG=
==========

to

==========
Remove toggle of Android payment apps in settings

BUG=700480
==========

[gogerald1, 2017-03-13 17:56:09]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 17:56:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 18:33:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 18:33:44]

Dry run: This issue passed the CQ dry run.

[gogerald1, 2017-03-13 19:04:48]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 19:05:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2017-03-13 19:15:31]

gogerald@chromium.org changed reviewers:
+ rouslan@chromium.org, tedchoc@chromium.org

[gogerald1, 2017-03-13 19:15:31]

Hi tedchoc@ and rouslan@, PTAL,

[please use gerrit instead, 2017-03-13 19:29:46]

Payments LGTM, but please get a review from Ted as well.

Why do we need to add the new horizontal divider class?

[gogerald1, 2017-03-13 20:00:06]

On 2017/03/13 19:29:46, ಠ_ಠ wrote:
> Payments LGTM, but please get a review from Ted as well.
> 
> Why do we need to add the new horizontal divider class?

I split it out of ChromeSwitchPreference to be used in both places to avoid
duplication. For same reason (might WAI), there is no horizontal divider for the
last listed payment apps, so I need to draw it programmatically.

[commit-bot: I haz the power, 2017-03-13 20:16:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 20:16:33]

Dry run: This issue passed the CQ dry run.

[Ted C, 2017-03-14 20:03:20]

On 2017/03/13 20:00:06, gogerald1 wrote:
> On 2017/03/13 19:29:46, ಠ_ಠ wrote:
> > Payments LGTM, but please get a review from Ted as well.
> > 
> > Why do we need to add the new horizontal divider class?
> 
> I split it out of ChromeSwitchPreference to be used in both places to avoid
> duplication. For same reason (might WAI), there is no horizontal divider for
the
> last listed payment apps, so I need to draw it programmatically.

lgtm

[gogerald1, 2017-03-14 20:20:52]

The CQ bit was checked by gogerald@chromium.org

[commit-bot: I haz the power, 2017-03-14 20:21:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 22:00:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489522852657670,
"parent_rev": "9b37df50ff912dd36e755d4a49d85b8052eca37e", "commit_rev":
"320588fcc48f1e0419ad64e36f55eb5f508c3298"}

[commit-bot: I haz the power, 2017-03-14 22:01:13]

Description was changed from

==========
Remove toggle of Android payment apps in settings

BUG=700480
==========

to

==========
Remove toggle of Android payment apps in settings

BUG=700480

Review-Url: https://codereview.chromium.org/2748793003
Cr-Commit-Position: refs/heads/master@{#456853}
Committed:
https://chromium.googlesource.com/chromium/src/+/320588fcc48f1e0419ad64e36f55...
==========

[commit-bot: I haz the power, 2017-03-14 22:01:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/320588fcc48f1e0419ad64e36f55...