Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2748783002: Roll buildtools b3771b1935..95345544a0 (Closed)

Created:
3 years, 9 months ago by sdefresne
Modified:
3 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools b3771b1935..95345544a0 In order to roll GN d8754536ca..5dd3a2137b (r446079:r456385) and pick up the following changes: 5d93a97915ac Include "public" source files in generated Xcode project. 379e35f6f3ea Fix GN bootstrap. 122c4da76a70 Remove base::StringValue eacf0f430d80 Add support for customizing GN's args text. 698727682cc7 gn: Tweak precompiled_header docs. f8d29f02e821 [GN] Update visual_studio_writer to use SDK kit 14393 instead of 10586. b7fb5fc4195b GN docs: update the example of declare_args(). 6d9996c865dc Fix auto raw pointer deduction on linux 8171050893e6 docs: Change "ChromeOS" to "Chrome OS". ddb3cdad576e Fix GN bootstrap 5047017bdca8 [tracing] Implement polling in MemoryDumpManager 809b8f0ca34b Add vim support for highlighting GN target names 0fcc08c5d93f gn: fix fuzzer bug in parser for stack local e46620f10101 Improve vim's 'gf' for BUILD.gn files 8598442a7122 Update the GN reference.md documentation. TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2748783002 Cr-Commit-Position: refs/heads/master@{#456412} Committed: https://chromium.googlesource.com/chromium/src/+/125fa0a2d0d58f7a6b8b90a7ff93443db6c73c0c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
sdefresne
3 years, 9 months ago (2017-03-13 16:18:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748783002/1
3 years, 9 months ago (2017-03-13 16:18:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/125fa0a2d0d58f7a6b8b90a7ff93443db6c73c0c
3 years, 9 months ago (2017-03-13 17:21:38 UTC) #6
Dirk Pranke
3 years, 9 months ago (2017-03-13 21:12:56 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698