Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issue 2748743002: Headless: Strip X-DevTools-Emulate-Network-Conditions-Client-Id (Closed)

Created:
3 years, 9 months ago by alex clarke (OOO till 29th)
Modified:
3 years, 9 months ago
Reviewers:
Sami
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Headless: Strip X-DevTools-Emulate-Network-Conditions-Client-Id This header is added when the DevTools Network domain is active. It's supposed to be stripped before the fetch is sent down the wire. BUG=546953, 698905 Review-Url: https://codereview.chromium.org/2748743002 Cr-Commit-Position: refs/heads/master@{#456486} Committed: https://chromium.googlesource.com/chromium/src/+/43f04a7037dac960a00cb0c4ea7257369610921c

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change capitalization #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -0 lines) Patch
M headless/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A headless/lib/browser/headless_network_delegate.h View 1 chunk +74 lines, -0 lines 0 comments Download
A headless/lib/browser/headless_network_delegate.cc View 1 chunk +93 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_url_request_context_getter.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M headless/lib/headless_devtools_client_browsertest.cc View 1 2 chunks +48 lines, -0 lines 0 comments Download
M headless/test/test_protocol_handler.h View 2 chunks +6 lines, -0 lines 0 comments Download
M headless/test/test_protocol_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
alex clarke (OOO till 29th)
3 years, 9 months ago (2017-03-13 14:21:23 UTC) #3
Sami
lgtm, thanks! https://codereview.chromium.org/2748743002/diff/1/headless/lib/headless_devtools_client_browsertest.cc File headless/lib/headless_devtools_client_browsertest.cc (right): https://codereview.chromium.org/2748743002/diff/1/headless/lib/headless_devtools_client_browsertest.cc#newcode896 headless/lib/headless_devtools_client_browsertest.cc:896: class DevtoolsHeaderStrippingTest : public HeadlessAsyncDevTooledBrowserTest, nit: DevTools
3 years, 9 months ago (2017-03-13 18:16:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748743002/20001
3 years, 9 months ago (2017-03-13 19:54:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/43f04a7037dac960a00cb0c4ea7257369610921c
3 years, 9 months ago (2017-03-13 21:20:59 UTC) #13
alex clarke (OOO till 29th)
3 years, 9 months ago (2017-03-17 08:36:44 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/2748743002/diff/1/headless/lib/headless_devto...
File headless/lib/headless_devtools_client_browsertest.cc (right):

https://codereview.chromium.org/2748743002/diff/1/headless/lib/headless_devto...
headless/lib/headless_devtools_client_browsertest.cc:896: class
DevtoolsHeaderStrippingTest : public HeadlessAsyncDevTooledBrowserTest,
On 2017/03/13 18:16:12, Sami wrote:
> nit: DevTools

Done.

Powered by Google App Engine
This is Rietveld 408576698