Issue 27487003: Third wave of Win64 warning cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27487003: Third wave of Win64 warning cleanup (Closed)

Created:
7 years, 2 months ago by robertphillips

Modified:
7 years, 2 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

In service of Skia issue 1695 (64-bit Mac and Windows bots reporting warnings - https://code.google.com/p/skia/issues/detail?id=1695)

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -41 lines)			Patch
M	bench/benchmain.cpp	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	gm/canvasstate.cpp	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/shadertext.cpp	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/texteffects.cpp	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkTDArray.h	View	1 2 3 4	10 chunks	+19 lines, -18 lines	0 comments	Download
M	src/gpu/gl/GrGLBufferImpl.cpp	View	1 2 3 4	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.cpp	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	1 2 3 4	3 chunks	+4 lines, -3 lines	0 comments	Download
M	src/pdf/SkTSet.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	src/utils/SkPDFRasterizer.cpp	View	1 2 3 4	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/BitmapCopyTest.cpp	View	1 2 3 4	3 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/PictureTest.cpp	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

bsalomon

lgtm, though I think we should make SK_ARRAY_COUNT do the cast itself (and perhaps statically ...

7 years, 2 months ago (2013-10-16 17:40:31 UTC) #2

robertphillips

7 years, 2 months ago (2013-10-16 17:49:06 UTC) #3

Message was sent while issue was closed.

I agree (r.e., making ARRAY_COUNT return an int) and will incorporate that into
this cleanup cycle.

committed as r11817