[DevTools] Clear session storage

[DevTools] Clear session storage

BUG=633970
Review-Url: https://codereview.chromium.org/2748693003
Cr-Commit-Position: refs/heads/master@{#456535}
Committed: https://chromium.googlesource.com/chromium/src/+/712524e1b297823b7f50ba08ebb4397b7a781253

[eostroukhov, 2017-03-13 20:32:58]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 20:33:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov, 2017-03-13 20:34:16]

eostroukhov@chromium.org changed reviewers:
+ caseq@chromium.org, dgozman@chromium.org

[eostroukhov, 2017-03-13 20:34:16]

Please take a look.

[caseq, 2017-03-13 20:56:50]

lgtm

https://codereview.chromium.org/2748693003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js
(right):

https://codereview.chromium.org/2748693003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js:156:
console.assert(storage);
let's drop this, NPE that would happen on next line would be as good as assert
:-)

[eostroukhov, 2017-03-13 21:33:45]

Thanks for the review. I removed the assert, submitting now.

https://codereview.chromium.org/2748693003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js
(right):

https://codereview.chromium.org/2748693003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js:156:
console.assert(storage);
On 2017/03/13 20:56:50, caseq wrote:
> let's drop this, NPE that would happen on next line would be as good as assert
> :-)

Done.

[eostroukhov, 2017-03-13 21:33:49]

The CQ bit was checked by eostroukhov@chromium.org

[eostroukhov, 2017-03-13 21:33:50]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2748693003/#ps20001
(title: "[DevTools] Clear session storage")

[commit-bot: I haz the power, 2017-03-13 21:34:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 23:20:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489440829906630,
"parent_rev": "1d2582b92877456a786a0f3b483dc8080c322fdf", "commit_rev":
"712524e1b297823b7f50ba08ebb4397b7a781253"}

[commit-bot: I haz the power, 2017-03-13 23:21:34]

Description was changed from

==========
[DevTools] Clear session storage

BUG=633970
==========

to

==========
[DevTools] Clear session storage

BUG=633970

Review-Url: https://codereview.chromium.org/2748693003
Cr-Commit-Position: refs/heads/master@{#456535}
Committed:
https://chromium.googlesource.com/chromium/src/+/712524e1b297823b7f50ba08ebb4...
==========

[commit-bot: I haz the power, 2017-03-13 23:21:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/712524e1b297823b7f50ba08ebb4...