Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2748693003: [DevTools] Clear session storage (Closed)

Created:
3 years, 9 months ago by eostroukhov
Modified:
3 years, 9 months ago
Reviewers:
caseq, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Clear session storage BUG=633970 Review-Url: https://codereview.chromium.org/2748693003 Cr-Commit-Position: refs/heads/master@{#456535} Committed: https://chromium.googlesource.com/chromium/src/+/712524e1b297823b7f50ba08ebb4397b7a781253

Patch Set 1 #

Total comments: 2

Patch Set 2 : [DevTools] Clear session storage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -23 lines) Patch
M third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js View 1 3 chunks +19 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
eostroukhov
Please take a look.
3 years, 9 months ago (2017-03-13 20:34:16 UTC) #4
caseq
lgtm https://codereview.chromium.org/2748693003/diff/1/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js File third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js (right): https://codereview.chromium.org/2748693003/diff/1/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js#newcode156 third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js:156: console.assert(storage); let's drop this, NPE that would happen ...
3 years, 9 months ago (2017-03-13 20:56:50 UTC) #5
eostroukhov
Thanks for the review. I removed the assert, submitting now. https://codereview.chromium.org/2748693003/diff/1/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js File third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js (right): https://codereview.chromium.org/2748693003/diff/1/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js#newcode156 ...
3 years, 9 months ago (2017-03-13 21:33:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748693003/20001
3 years, 9 months ago (2017-03-13 21:34:37 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 23:21:35 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/712524e1b297823b7f50ba08ebb4...

Powered by Google App Engine
This is Rietveld 408576698