third_party/WebKit/Source/web/WebFrame.cpp - Issue 2748603002: Add a lifecycle state machine for Page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebFrame.cpp

Issue 2748603002: Add a lifecycle state machine for Page (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebFrame.cpp

diff --git a/third_party/WebKit/Source/web/WebFrame.cpp b/third_party/WebKit/Source/web/WebFrame.cpp

index 96c4787f68761896b6047a5fb31ef8cd3cb5bd57..dbf1fdf8d05edb59e129beaeaf587413a068c8ea 100644

--- a/third_party/WebKit/Source/web/WebFrame.cpp

+++ b/third_party/WebKit/Source/web/WebFrame.cpp

@@ -30,7 +30,7 @@ namespace blink {

bool WebFrame::swap(WebFrame* frame) {

using std::swap;

Frame* oldFrame = toImplBase()->frame();

- if (oldFrame->isDetaching())

+ if (!oldFrame->isAttached())

return false;

// Unload the current Document in this frame: this calls unload handlers,

« no previous file with comments | « third_party/WebKit/Source/core/page/Page.cpp ('k') | no next file » | no next file with comments »