third_party/WebKit/Source/core/page/Page.cpp - Issue 2748603002: Add a lifecycle state machine for Page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2748603002: Add a lifecycle state machine for Page (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/Page.cpp

diff --git a/third_party/WebKit/Source/core/page/Page.cpp b/third_party/WebKit/Source/core/page/Page.cpp

index 0a37141dc1744a1af1fce1681fa600db04f7a21b..b3d6d6d9f407fbada38c478af83506049147e535 100644

--- a/third_party/WebKit/Source/core/page/Page.cpp

+++ b/third_party/WebKit/Source/core/page/Page.cpp

@@ -648,7 +648,10 @@ void Page::willCloseLayerTreeView(WebLayerTreeView& layerTreeView,

void Page::willBeDestroyed() {

Frame* mainFrame = m_mainFrame;

- mainFrame->detach(FrameDetachType::Remove);

+ // TODO(sashab): Remove this check, the call to detach() here should always

+ // work.

+ if (mainFrame->isAttached())

+ mainFrame->detach(FrameDetachType::Remove);

ASSERT(allPages().contains(this));

allPages().erase(this);