Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2748523002: Get clang updates to work with VS 2017 (Closed)

Created:
3 years, 9 months ago by brucedawson
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Get clang updates to work with VS 2017 Clang needs to grab a copy of msdia140.dll. It tries to grab it from the compiler that is being used to build Chrome, but it uses gyp to get the compiler information, and gyp doesn't yet know about VS 2017. Until it does this patch teaches clang enough to make it work, based on other scripts setting GYP_MSVS_OVERRIDE_PATH. Do not submit as-is. This should either be simplified to just the first changed line, or modified to fully remove the gyp dependency. BUG=700524

Patch Set 1 #

Patch Set 2 : Pull to latest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M tools/clang/scripts/update.py View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (5 generated)
brucedawson
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-11 01:37:14 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748523002/1
3 years, 9 months ago (2017-03-11 01:37:31 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-11 02:27:48 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 9 months ago (2017-03-11 02:27:49 UTC) #4
brucedawson
3 years, 9 months ago (2017-03-13 21:59:42 UTC) #5 
Description was changed from

==========
Get clang updates to work with VS 2017

Clang needs to grab a copy of msdia140.dll. It tries to grab it from the
compiler that is being used to build Chrome, but it uses gyp to get the
compiler information, and gyp doesn't yet know about VS 2017. Until it
does this patch teaches clang enough to make it work, based on other
scripts setting GYP_MSVS_OVERRIDE_PATH.

BUG=700524
==========

to

==========
Get clang updates to work with VS 2017

Clang needs to grab a copy of msdia140.dll. It tries to grab it from the
compiler that is being used to build Chrome, but it uses gyp to get the
compiler information, and gyp doesn't yet know about VS 2017. Until it
does this patch teaches clang enough to make it work, based on other
scripts setting GYP_MSVS_OVERRIDE_PATH.

Do not submit as-is. This should either be simplified to just the first
changed line, or modified to fully remove the gyp dependency.

BUG=700524
==========

Powered by Google App Engine
This is Rietveld 408576698