Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/clang/scripts/update.py

Issue 2748523002: Get clang updates to work with VS 2017 (Closed)
Patch Set: Pull to latest Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/scripts/update.py
diff --git a/tools/clang/scripts/update.py b/tools/clang/scripts/update.py
index af2b34afc4d93cbc66537108d31f10af2292f762..b838752af39d7177c509b8565e6fd4b97216ca08 100755
--- a/tools/clang/scripts/update.py
+++ b/tools/clang/scripts/update.py
@@ -364,6 +364,16 @@ def GetVSVersion():
# or a system-wide installation otherwise.
sys.path.append(os.path.join(CHROMIUM_DIR, 'tools', 'gyp', 'pylib'))
import gyp.MSVSVersion
+ #if 'GYP_MSVS_OVERRIDE_PATH' in os.environ:
+ # return gyp.MSVSVersion.VisualStudioVersion('2017',
+ # 'Visual Studio 2017',
+ # solution_version='12.00',
+ # project_version='15.0',
+ # flat_sln=False,
+ # uses_vcxproj=True,
+ # path=os.environ['GYP_MSVS_OVERRIDE_PATH'],
+ # sdk_based=False,
+ # default_toolset='v141')
vs_version = gyp.MSVSVersion.SelectVisualStudioVersion(
vs_toolchain.GetVisualStudioVersion())
return vs_version
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698