Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: src/inspector/v8-inspector-impl.cc

Issue 2748503002: [inspector] changed a way of preserving stepping between tasks (Closed)
Patch Set: removed willExecuteScript from tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/inspector/v8-inspector-impl.cc
diff --git a/src/inspector/v8-inspector-impl.cc b/src/inspector/v8-inspector-impl.cc
index 34e41208acd7cbe788a79b3f0afb63e49463b438..d146aa814cab02d9acd14415e01878bfb103e002 100644
--- a/src/inspector/v8-inspector-impl.cc
+++ b/src/inspector/v8-inspector-impl.cc
@@ -94,15 +94,7 @@ v8::MaybeLocal<v8::Value> V8InspectorImpl::runCompiledScript(
v8::Local<v8::Context> context, v8::Local<v8::Script> script) {
v8::MicrotasksScope microtasksScope(m_isolate,
v8::MicrotasksScope::kRunMicrotasks);
- int groupId = contextGroupId(context);
- if (V8DebuggerAgentImpl* agent = enabledDebuggerAgentForGroup(groupId))
- agent->willExecuteScript(script->GetUnboundScript()->GetId());
- v8::MaybeLocal<v8::Value> result = script->Run(context);
- // Get agent from the map again, since it could have detached during script
- // execution.
- if (V8DebuggerAgentImpl* agent = enabledDebuggerAgentForGroup(groupId))
- agent->didExecuteScript();
- return result;
+ return script->Run(context);
}
v8::MaybeLocal<v8::Value> V8InspectorImpl::callFunction(
@@ -124,16 +116,7 @@ v8::MaybeLocal<v8::Value> V8InspectorImpl::callFunction(
v8::Local<v8::Value> receiver, int argc, v8::Local<v8::Value> info[],
v8::MicrotasksScope::Type runMicrotasks) {
v8::MicrotasksScope microtasksScope(m_isolate, runMicrotasks);
- int groupId = contextGroupId(context);
- if (V8DebuggerAgentImpl* agent = enabledDebuggerAgentForGroup(groupId))
- agent->willExecuteScript(function->ScriptId());
- v8::MaybeLocal<v8::Value> result =
- function->Call(context, receiver, argc, info);
- // Get agent from the map again, since it could have detached during script
- // execution.
- if (V8DebuggerAgentImpl* agent = enabledDebuggerAgentForGroup(groupId))
- agent->didExecuteScript();
- return result;
+ return function->Call(context, receiver, argc, info);
}
v8::MaybeLocal<v8::Value> V8InspectorImpl::compileAndRunInternalScript(
@@ -287,17 +270,9 @@ void V8InspectorImpl::resetContextGroup(int contextGroupId) {
void V8InspectorImpl::willExecuteScript(v8::Local<v8::Context> context,
int scriptId) {
- if (V8DebuggerAgentImpl* agent =
- enabledDebuggerAgentForGroup(contextGroupId(context))) {
- agent->willExecuteScript(scriptId);
- }
}
void V8InspectorImpl::didExecuteScript(v8::Local<v8::Context> context) {
- if (V8DebuggerAgentImpl* agent =
- enabledDebuggerAgentForGroup(contextGroupId(context))) {
- agent->didExecuteScript();
- }
}
void V8InspectorImpl::idleStarted() {

Powered by Google App Engine
This is Rietveld 408576698