src/isolate.cc - Issue 2748503002: [inspector] changed a way of preserving stepping between tasks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 2748503002: [inspector] changed a way of preserving stepping between tasks (Closed)

Patch Set: removed willExecuteScript from tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index de330d138655940d3d382b61f538d2770ae1d902..c4c4e2fbbb80d38b37a6352da416ee90c3305041 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -3284,8 +3284,7 @@ void Isolate::FireCallCompletedCallback() {

v8::MicrotasksPolicy::kAuto;

if (run_microtasks) RunMicrotasks();

- // Prevent stepping from spilling into the next call made by the embedder.

- if (debug()->is_active()) debug()->ClearStepping();

+ if (debug()->is_active()) debug()->HandleCallCompleted();

if (call_completed_callbacks_.is_empty()) return;

// Fire callbacks. Increase call depth to prevent recursive callbacks.