No 'prefs' state is necessary for an active file.

No 'prefs' state is necessary for an active file and it interferes
with reading the file for the previous run.

Also add a DCHECK to have future users not set a pref-key for "active"
files since it's not necessary as the file contents itself are
updated.

BUG=696721
Review-Url: https://codereview.chromium.org/2748463004
Cr-Commit-Position: refs/heads/master@{#456695}
Committed: https://chromium.googlesource.com/chromium/src/+/4ff719bc73eb4d3d6b780f15392baffcf77ee062

[bcwhite, 2017-03-10 23:00:34]

The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run

[bcwhite, 2017-03-10 23:00:59]

The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 23:00:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bcwhite, 2017-03-10 23:30:32]

The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 23:31:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bcwhite, 2017-03-10 23:33:23]

bcwhite@chromium.org changed reviewers:
+ asvitkine@chromium.org, scottmg@chromium.org

[bcwhite, 2017-03-10 23:38:31]

Description was changed from

==========
No 'prefs' state is necessary for an active file and it interferes with reading
the file for the previous run.

BUG=696721
==========

to

==========
No 'prefs' state is necessary for an active file and it interferes
with reading the file for the previous run.

Also add a DCHECK to have future users not set a pref-key for "active"
files since it's not necessary as the file contents itself are
updated.

BUG=696721
==========

[commit-bot: I haz the power, 2017-03-10 23:54:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 23:54:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bcwhite, 2017-03-11 00:15:54]

The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 00:16:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 01:02:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 01:02:23]

Dry run: This issue passed the CQ dry run.

[Sigurður Ásgeirsson, 2017-03-13 16:47:10]

siggi@chromium.org changed reviewers:
+ siggi@chromium.org

[Sigurður Ásgeirsson, 2017-03-13 16:47:11]

rubber stamp lgtm as Scott's OOO this week.

[Alexei Svitkine (slow), 2017-03-13 21:29:11]

lgtm

[bcwhite, 2017-03-14 13:14:34]

The CQ bit was checked by bcwhite@chromium.org

[commit-bot: I haz the power, 2017-03-14 13:14:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 14:05:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489497274602740,
"parent_rev": "08d70eff91706d41bf37315cc7061fa2efcc6d0c", "commit_rev":
"4ff719bc73eb4d3d6b780f15392baffcf77ee062"}

[commit-bot: I haz the power, 2017-03-14 14:06:30]

Description was changed from

==========
No 'prefs' state is necessary for an active file and it interferes
with reading the file for the previous run.

Also add a DCHECK to have future users not set a pref-key for "active"
files since it's not necessary as the file contents itself are
updated.

BUG=696721
==========

to

==========
No 'prefs' state is necessary for an active file and it interferes
with reading the file for the previous run.

Also add a DCHECK to have future users not set a pref-key for "active"
files since it's not necessary as the file contents itself are
updated.

BUG=696721

Review-Url: https://codereview.chromium.org/2748463004
Cr-Commit-Position: refs/heads/master@{#456695}
Committed:
https://chromium.googlesource.com/chromium/src/+/4ff719bc73eb4d3d6b780f15392b...
==========

[commit-bot: I haz the power, 2017-03-14 14:06:31]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4ff719bc73eb4d3d6b780f15392b...