Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 27484002: Allow '.' in user name on gclient ssh connection (Closed)

Created:
7 years, 2 months ago by kangil_
Modified:
7 years, 2 months ago
Reviewers:
iannucci, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Allow '.' in user name on gclient ssh connection For example, my id is 'kangil.han', but it fails during parsing. So this patch fixes it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=228937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gclient_utils.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kangil_
review please? :)
7 years, 2 months ago (2013-10-16 08:06:30 UTC) #1
M-A Ruel
Eh, this regexp dates back from 2009. lgtm
7 years, 2 months ago (2013-10-16 16:15:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/27484002/1
7 years, 2 months ago (2013-10-16 17:26:18 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-16 17:28:12 UTC) #4
Message was sent while issue was closed.
Change committed as 228937

Powered by Google App Engine
This is Rietveld 408576698