gclient_utils.py - Issue 27484002: Allow '.' in user name on gclient ssh connection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gclient_utils.py

Issue 27484002: Allow '.' in user name on gclient ssh connection (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gclient_utils.py

diff --git a/gclient_utils.py b/gclient_utils.py

index 80eb816b12dc1c540eb72c043c118e3d36dc5dc4..e77137f3eb05ef207b430e06b5fc57e38edd8b62 100644

--- a/gclient_utils.py

+++ b/gclient_utils.py

@@ -33,7 +33,7 @@ def SplitUrlRevision(url):

"""Splits url and returns a two-tuple: url, rev"""

if url.startswith('ssh:'):

# Make sure ssh://user-name@example.com/~/test.git@stable works

- regex = r'(ssh://(?:[-\w]+@)?[-\w:\.]+/[-~\w\./]+)(?:@(.+))?'

+ regex = r'(ssh://(?:[-.\w]+@)?[-\w:\.]+/[-~\w\./]+)(?:@(.+))?'

components = re.search(regex, url).groups()

else:

components = url.split('@', 1)

« no previous file with comments | « no previous file | no next file » | no next file with comments »