Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2748383004: [Compiler] Move static FinishCode function into CodeGenerator. (Closed)

Created:
3 years, 9 months ago by bbudge
Modified:
3 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Compiler] Move static FinishCode function into CodeGenerator. - Adds a FinishCode method to CodeGenerator, and implements it for all platforms. ARM and ARM64 flush constants, all other platforms do nothing. - Remove old static free function. LOG=N BUG=none Review-Url: https://codereview.chromium.org/2748383004 Cr-Commit-Position: refs/heads/master@{#43990} Committed: https://chromium.googlesource.com/v8/v8/+/503103ebcf3863c2226b92360c0a3949f7da1bd4

Patch Set 1 #

Patch Set 2 : Add MIPS64. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/code-generator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/code-generator-impl.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
bbudge
Going through some of dcarney@'s TODOs.
3 years, 9 months ago (2017-03-16 18:46:07 UTC) #10
bbudge
On 2017/03/16 18:46:07, bbudge wrote: > Going through some of dcarney@'s TODOs Friendly ping in ...
3 years, 9 months ago (2017-03-20 21:20:27 UTC) #11
Benedikt Meurer
Sorry for the delay. LGTM
3 years, 9 months ago (2017-03-21 04:51:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748383004/20001
3 years, 9 months ago (2017-03-21 16:00:04 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 16:27:36 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/503103ebcf3863c2226b92360c0a3949f7d...

Powered by Google App Engine
This is Rietveld 408576698