Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 2748353004: Only propagate reload errors when there are Dart frames on the stack. (Closed)
Patch Set: rmacnak review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 954f24e6a55799ead125c570499d447097bb3dcc..ef6e48a5e845b7f7b978b05982e1ee137accd952 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -1366,10 +1366,7 @@ class Isolate extends ServiceObjectOwner implements M.Isolate {
}
void _handleIsolateReloadEvent(ServiceEvent event) {
- if (event.reloadError != null) {
- // Failure.
- print('Reload failed: ${event.reloadError}');
- } else {
+ if (event.reloadError == null) {
_cache.clear();
}
}
@@ -2113,7 +2110,7 @@ class ServiceEvent extends ServiceObject {
DartError error;
String extensionRPC;
Instance exception;
- Instance reloadError;
+ DartError reloadError;
bool atAsyncSuspension;
Instance inspectee;
ByteData data;
« no previous file with comments | « no previous file | runtime/observatory/tests/service/bad_reload/v1/main.dart » ('j') | runtime/vm/isolate_reload.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698