Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: runtime/observatory/lib/src/service/object.dart

Issue 2748353004: Only propagate reload errors when there are Dart frames on the stack. (Closed)
Patch Set: rmacnak review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of service; 5 part of service;
6 6
7 // Some value smaller than the object ring, so requesting a large array 7 // Some value smaller than the object ring, so requesting a large array
8 // doesn't result in an expired ref because the elements lapped it in the 8 // doesn't result in an expired ref because the elements lapped it in the
9 // object ring. 9 // object ring.
10 const int kDefaultFieldLimit = 100; 10 const int kDefaultFieldLimit = 100;
(...skipping 1348 matching lines...) Expand 10 before | Expand all | Expand 10 after
1359 if (pause != null) { 1359 if (pause != null) {
1360 params['pause'] = pause; 1360 params['pause'] = pause;
1361 } 1361 }
1362 return invokeRpc('reloadSources', params).then((result) { 1362 return invokeRpc('reloadSources', params).then((result) {
1363 _cache.clear(); 1363 _cache.clear();
1364 return result; 1364 return result;
1365 }); 1365 });
1366 } 1366 }
1367 1367
1368 void _handleIsolateReloadEvent(ServiceEvent event) { 1368 void _handleIsolateReloadEvent(ServiceEvent event) {
1369 if (event.reloadError != null) { 1369 if (event.reloadError == null) {
1370 // Failure.
1371 print('Reload failed: ${event.reloadError}');
1372 } else {
1373 _cache.clear(); 1370 _cache.clear();
1374 } 1371 }
1375 } 1372 }
1376 1373
1377 /// Fetches and builds the class hierarchy for this isolate. Returns the 1374 /// Fetches and builds the class hierarchy for this isolate. Returns the
1378 /// Object class object. 1375 /// Object class object.
1379 Future<Class> getClassHierarchy() { 1376 Future<Class> getClassHierarchy() {
1380 return invokeRpc('getClassList', {}) 1377 return invokeRpc('getClassList', {})
1381 .then(_loadClasses) 1378 .then(_loadClasses)
1382 .then(_buildClassHierarchy); 1379 .then(_buildClassHierarchy);
(...skipping 723 matching lines...) Expand 10 before | Expand all | Expand 10 after
2106 } 2103 }
2107 2104
2108 String kind; 2105 String kind;
2109 DateTime timestamp; 2106 DateTime timestamp;
2110 List<M.Breakpoint> pauseBreakpoints; 2107 List<M.Breakpoint> pauseBreakpoints;
2111 Breakpoint breakpoint; 2108 Breakpoint breakpoint;
2112 Frame topFrame; 2109 Frame topFrame;
2113 DartError error; 2110 DartError error;
2114 String extensionRPC; 2111 String extensionRPC;
2115 Instance exception; 2112 Instance exception;
2116 Instance reloadError; 2113 DartError reloadError;
2117 bool atAsyncSuspension; 2114 bool atAsyncSuspension;
2118 Instance inspectee; 2115 Instance inspectee;
2119 ByteData data; 2116 ByteData data;
2120 int count; 2117 int count;
2121 String reason; 2118 String reason;
2122 String exceptions; 2119 String exceptions;
2123 String bytesAsString; 2120 String bytesAsString;
2124 Map logRecord; 2121 Map logRecord;
2125 String extensionKind; 2122 String extensionKind;
2126 Map extensionData; 2123 Map extensionData;
(...skipping 2440 matching lines...) Expand 10 before | Expand all | Expand 10 after
4567 var v = list[i]; 4564 var v = list[i];
4568 if ((v is Map) && _isServiceMap(v)) { 4565 if ((v is Map) && _isServiceMap(v)) {
4569 list[i] = owner.getFromMap(v); 4566 list[i] = owner.getFromMap(v);
4570 } else if (v is List) { 4567 } else if (v is List) {
4571 _upgradeList(v, owner); 4568 _upgradeList(v, owner);
4572 } else if (v is Map) { 4569 } else if (v is Map) {
4573 _upgradeMap(v, owner); 4570 _upgradeMap(v, owner);
4574 } 4571 }
4575 } 4572 }
4576 } 4573 }
OLDNEW
« no previous file with comments | « no previous file | runtime/observatory/tests/service/bad_reload/v1/main.dart » ('j') | runtime/vm/isolate_reload.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698