Moving ChildProcessCreationParams from content to base.

Moving ChildProcessCreationParams from content to base.

This is the first step in moving process launching on Android to base.

BUG=702316
TBR=yfriedman@chromium.org

Review-Url: https://codereview.chromium.org/2748343006
Cr-Commit-Position: refs/heads/master@{#458128}
Committed: https://chromium.googlesource.com/chromium/src/+/62459bb8ae11cebff350dc7f0828d63906cac60f

[Jay Civelli, 2017-03-16 19:10:09]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[Jay Civelli, 2017-03-16 19:10:20]

Description was changed from

==========
Moving ChildProcessCreationParams from content to base.

This is the first step in moving process launching on Android to base.

BUG=702316
==========

to

==========
Moving ChildProcessCreationParams from content to base.

This is the first step in moving process launching on Android to base.

BUG=702316
==========

[Jay Civelli, 2017-03-16 19:10:21]

jcivelli@chromium.org changed reviewers:
+ boliu@chromium.org

[commit-bot: I haz the power, 2017-03-16 19:10:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 19:41:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 19:41:55]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[boliu, 2017-03-16 20:42:07]

content lgtm

probably missed updating a bunch of imports in chrome and android_webview

https://codereview.chromium.org/2748343006/diff/1/base/android/java/src/org/c...
File
base/android/java/src/org/chromium/base/process_launcher/ChildProcessCreationParams.java
(right):

https://codereview.chromium.org/2748343006/diff/1/base/android/java/src/org/c...
base/android/java/src/org/chromium/base/process_launcher/ChildProcessCreationParams.java:5:
package org.chromium.base.process_launcher;
should we add the same owners to this directory..?

https://codereview.chromium.org/2748343006/diff/1/base/android/java/src/org/c...
base/android/java/src/org/chromium/base/process_launcher/ChildProcessCreationParams.java:41:
// TODO(boliu): Make package visible once WebApk is fixed.
remove this, not applicable anymore now that this isn't in the same package as
ChildProcessLauncher

[Jay Civelli, 2017-03-16 21:09:53]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 21:10:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jay Civelli, 2017-03-16 21:11:10]

https://codereview.chromium.org/2748343006/diff/1/base/android/java/src/org/c...
File
base/android/java/src/org/chromium/base/process_launcher/ChildProcessCreationParams.java
(right):

https://codereview.chromium.org/2748343006/diff/1/base/android/java/src/org/c...
base/android/java/src/org/chromium/base/process_launcher/ChildProcessCreationParams.java:5:
package org.chromium.base.process_launcher;
On 2017/03/16 20:42:07, boliu wrote:
> should we add the same owners to this directory..?

Done.

https://codereview.chromium.org/2748343006/diff/1/base/android/java/src/org/c...
base/android/java/src/org/chromium/base/process_launcher/ChildProcessCreationParams.java:41:
// TODO(boliu): Make package visible once WebApk is fixed.
On 2017/03/16 20:42:07, boliu wrote:
> remove this, not applicable anymore now that this isn't in the same package as
> ChildProcessLauncher

Done.

[commit-bot: I haz the power, 2017-03-16 22:52:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 22:52:45]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Jay Civelli, 2017-03-16 23:33:41]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 23:34:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 01:07:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 01:07:11]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Jay Civelli, 2017-03-17 02:55:13]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 02:55:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jay Civelli, 2017-03-17 03:05:18]

Description was changed from

==========
Moving ChildProcessCreationParams from content to base.

This is the first step in moving process launching on Android to base.

BUG=702316
==========

to

==========
Moving ChildProcessCreationParams from content to base.

This is the first step in moving process launching on Android to base.

BUG=702316
TBR=yfriedman@chromium.org,
==========

[Jay Civelli, 2017-03-17 03:05:18]

jcivelli@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Jay Civelli, 2017-03-17 03:05:26]

Description was changed from

==========
Moving ChildProcessCreationParams from content to base.

This is the first step in moving process launching on Android to base.

BUG=702316
TBR=yfriedman@chromium.org,
==========

to

==========
Moving ChildProcessCreationParams from content to base.

This is the first step in moving process launching on Android to base.

BUG=702316
TBR=yfriedman@chromium.org
==========

[Jay Civelli, 2017-03-17 03:06:42]

TBRing yfriedman@ for OWNER review in base/BUILD.gn, build/android and
chrome/android for import change due to class move.

[Jay Civelli, 2017-03-17 03:06:50]

The CQ bit was unchecked by jcivelli@chromium.org

[Jay Civelli, 2017-03-17 03:06:51]

The CQ bit was checked by jcivelli@chromium.org

[Jay Civelli, 2017-03-17 03:06:51]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2748343006/#ps40001
(title: "Synced")

[commit-bot: I haz the power, 2017-03-17 03:07:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 03:56:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 03:56:39]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Yaron, 2017-03-17 15:25:20]

lgtm

[Jay Civelli, 2017-03-20 17:14:33]

The CQ bit was checked by jcivelli@chromium.org

[Jay Civelli, 2017-03-20 17:14:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org, boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2748343006/#ps60001
(title: "Fix build.")

[commit-bot: I haz the power, 2017-03-20 17:15:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 18:23:06]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490030073947310,
"parent_rev": "f24e5de44ba4a46b8d3a4af00e2c2c3cc1e48cdb", "commit_rev":
"62459bb8ae11cebff350dc7f0828d63906cac60f"}

[commit-bot: I haz the power, 2017-03-20 18:23:49]

Description was changed from

==========
Moving ChildProcessCreationParams from content to base.

This is the first step in moving process launching on Android to base.

BUG=702316
TBR=yfriedman@chromium.org
==========

to

==========
Moving ChildProcessCreationParams from content to base.

This is the first step in moving process launching on Android to base.

BUG=702316
TBR=yfriedman@chromium.org

Review-Url: https://codereview.chromium.org/2748343006
Cr-Commit-Position: refs/heads/master@{#458128}
Committed:
https://chromium.googlesource.com/chromium/src/+/62459bb8ae11cebff350dc7f0828...
==========

[commit-bot: I haz the power, 2017-03-20 18:23:51]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/62459bb8ae11cebff350dc7f0828...