Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Issue 2748333002: [kernel] offsets on direct property get/set (Closed)

Created:
3 years, 9 months ago by jensj
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, dart-fe-team+reviews_google.com, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -16 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart View 1 chunk +8 lines, -6 lines 0 comments Download
M pkg/kernel/binary.md View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/kernel/lib/binary/ast_from_binary.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/kernel/lib/binary/ast_to_binary.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/kernel/lib/transformations/mixin_full_resolution.dart View 2 chunks +4 lines, -2 lines 0 comments Download
A runtime/observatory/tests/service/step_through_property_get_test.dart View 1 chunk +78 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/step_through_property_set_test.dart View 1 chunk +78 lines, -0 lines 0 comments Download
M runtime/vm/kernel_binary.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
jensj
3 years, 9 months ago (2017-03-15 12:15:12 UTC) #2
Kevin Millikin (Google)
LGTM.
3 years, 9 months ago (2017-03-15 12:18:50 UTC) #3
Kevin Millikin (Google)
LGTM.
3 years, 9 months ago (2017-03-15 12:18:52 UTC) #4
ahe
Fasta changes: LGTM
3 years, 9 months ago (2017-03-15 12:21:28 UTC) #5
jensj
Committed patchset #1 (id:1) manually as 7577f6aaa052c9a1c309f13bf338b92bf4fb9fd0 (presubmit successful).
3 years, 9 months ago (2017-03-15 12:26:54 UTC) #7
jensj
reverting (https://codereview.chromium.org/2751083002/) as this relies on another CL that hasn't landed yet (https://codereview.chromium.org/2752753002#ps20001)
3 years, 9 months ago (2017-03-15 12:55:43 UTC) #9
jensj
3 years, 9 months ago (2017-03-21 13:43:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a6ea038643597cd383a352809a979531c00a51f0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698