Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2748323002: Pickup github update for brotli fuzz target. (Closed)

Created:
3 years, 9 months ago by eustas
Modified:
3 years, 9 months ago
CC:
chromium-reviews, fuzzing_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pickup github update for brotli fuzz target. https://github.com/google/brotli/commit/1ff78b877f0138064f0a0513267e8355affd4be8 Move fuzzer to third_party/brotli/fuzz. BUG=700667 Review-Url: https://codereview.chromium.org/2748323002 Cr-Commit-Position: refs/heads/master@{#457380} Committed: https://chromium.googlesource.com/chromium/src/+/5fd99fadaac4fa9d7b18593ef00d4ca20a3cdcf0

Patch Set 1 #

Patch Set 2 : Move fuzzer to brotli/fuzz #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -60 lines) Patch
M testing/libfuzzer/fuzzers/BUILD.gn View 1 1 chunk +0 lines, -10 lines 0 comments Download
M testing/libfuzzer/fuzzers/brotli_fuzzer.cc View 1 1 chunk +0 lines, -45 lines 0 comments Download
M third_party/brotli/BUILD.gn View 1 2 chunks +12 lines, -0 lines 0 comments Download
M third_party/brotli/README.chromium View 1 1 chunk +4 lines, -3 lines 0 comments Download
A third_party/brotli/fuzz/DEPS View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/brotli/fuzz/decode_fuzzer.cc View 1 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
eustas
3 years, 9 months ago (2017-03-15 12:02:09 UTC) #2
eustas
3 years, 9 months ago (2017-03-15 12:03:54 UTC) #4
mmoroz
LGTM, Thanks! But actually we should update brotli in Chromium and then move GN config ...
3 years, 9 months ago (2017-03-15 12:12:12 UTC) #5
mmoroz
On 2017/03/15 12:12:12, mmoroz wrote: > LGTM, Thanks! But actually we should update brotli in ...
3 years, 9 months ago (2017-03-15 12:13:12 UTC) #7
eustas
mmoroz@, please PTAL
3 years, 9 months ago (2017-03-15 13:32:50 UTC) #9
mmoroz
lgtm
3 years, 9 months ago (2017-03-15 13:57:39 UTC) #13
Kunihiko Sakamoto
lgtm
3 years, 9 months ago (2017-03-16 09:00:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748323002/20001
3 years, 9 months ago (2017-03-16 09:02:38 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 09:08:04 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5fd99fadaac4fa9d7b18593ef00d...

Powered by Google App Engine
This is Rietveld 408576698