Cleanup jobs which have failed.

chrome/browser/chromeos/printing/cups_print_job_notification.cc

Index: chrome/browser/chromeos/printing/cups_print_job_notification.cc
diff --git a/chrome/browser/chromeos/printing/cups_print_job_notification.cc b/chrome/browser/chromeos/printing/cups_print_job_notification.cc
index 25eba1000b58d425a1a7a6bae4254250f8477071..d2be94c070de6e9284a2acdf1d2836a4ddf52483 100644
--- a/chrome/browser/chromeos/printing/cups_print_job_notification.cc
+++ b/chrome/browser/chromeos/printing/cups_print_job_notification.cc
@@ -117,13 +117,15 @@ void CupsPrintJobNotification::ClickOnNotificationButton(int button_index) {
 
   switch (button_command) {
     case ButtonCommand::CANCEL_PRINTING:
-      if (print_job_manager->CancelPrintJob(print_job_)) {
-        // only clean up the nofitication if cancel was successful.
-        g_browser_process->notification_ui_manager()->CancelById(
-            GetNotificationId(), profile_id);
-        cancelled_by_user_ = true;
-        notification_manager_->OnPrintJobNotificationRemoved(this);
-      }
+      print_job_manager->CancelPrintJob(print_job_);
+      // print_job_ may be deleted by print_job_manager after cancellation.

[Carlson, 2017/03/16 18:36:48]

I don't understand what this comment means.  That it might already be deleted?

[skau, 2017/03/16 22:14:36]

It was supposed to mean that print_job_ is deleted sometime after CancelPrintJob
returned but we didn't guarantee when.  However, it's deleted in CancelPrintJob
now and the comment has been updated.

+      print_job_ = nullptr;
+
+      // only clean up the nofitication if cancel was successful.
+      g_browser_process->notification_ui_manager()->CancelById(
+          GetNotificationId(), profile_id);
+      cancelled_by_user_ = true;
+      notification_manager_->OnPrintJobNotificationRemoved(this);
       break;
     case ButtonCommand::PAUSE_PRINTING:
       print_job_manager->SuspendPrintJob(print_job_);