Cleanup jobs which have failed.

chrome/browser/chromeos/printing/cups_print_job_notification.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/printing/cups_print_job_notification.h"
 
 #include <memory>
 #include <string>
 #include <vector>
 
@@ skipping 99 matching lines @@
          static_cast<size_t>(button_index) < button_commands_->size());
 
   CupsPrintJobNotification::ButtonCommand button_command =
       button_commands_->at(button_index);
   CupsPrintJobManager* print_job_manager =
       CupsPrintJobManagerFactory::GetForBrowserContext(profile_);
   const ProfileID profile_id = NotificationUIManager::GetProfileID(profile_);
 
   switch (button_command) {
     case ButtonCommand::CANCEL_PRINTING:
-      if (print_job_manager->CancelPrintJob(print_job_)) {
-        // only clean up the nofitication if cancel was successful.
-        g_browser_process->notification_ui_manager()->CancelById(
-            GetNotificationId(), profile_id);
-        cancelled_by_user_ = true;
-        notification_manager_->OnPrintJobNotificationRemoved(this);
-      }
+      print_job_manager->CancelPrintJob(print_job_);
+      // print_job_ may be deleted by print_job_manager after cancellation.

[Carlson, 2017/03/16 18:36:48]

I don't understand what this comment means.  That it might already be deleted?

[skau, 2017/03/16 22:14:36]

It was supposed to mean that print_job_ is deleted sometime after CancelPrintJob
returned but we didn't guarantee when.  However, it's deleted in CancelPrintJob
now and the comment has been updated.

+      print_job_ = nullptr;
+
+      // only clean up the nofitication if cancel was successful.
+      g_browser_process->notification_ui_manager()->CancelById(
+          GetNotificationId(), profile_id);
+      cancelled_by_user_ = true;
+      notification_manager_->OnPrintJobNotificationRemoved(this);
       break;
     case ButtonCommand::PAUSE_PRINTING:
       print_job_manager->SuspendPrintJob(print_job_);
       break;
     case ButtonCommand::RESUME_PRINTING:
       print_job_manager->ResumePrintJob(print_job_);
       break;
     case ButtonCommand::GET_HELP:
       break;
   }
@@ skipping 199 matching lines @@
       icon = bundle.GetImageNamed(IDR_PRINT_NOTIFICATION_PLAY);
       break;
     case ButtonCommand::GET_HELP:
       icon = bundle.GetImageNamed(IDR_PRINT_NOTIFICATION_HELP);
       break;
   }
   return icon;
 }
 
 }  // namespace chromeos