Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1587)

Issue 2748253004: [cleanup] The %StringAdd runtime function is always called on Strings. (Closed)

Created:
3 years, 9 months ago by Benedikt Meurer
Modified:
3 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] The %StringAdd runtime function is always called on Strings. There's no point in trying to convert to a string, as this runtime function must always be called with Strings, otherwise there's a bug. R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2748253004 Cr-Commit-Position: refs/heads/master@{#43830} Committed: https://chromium.googlesource.com/v8/v8/+/ead696dc88add5d5416a273d9bccd8ef5d04d0ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M src/runtime/runtime-strings.cc View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Benedikt Meurer
3 years, 9 months ago (2017-03-15 12:10:52 UTC) #1
Benedikt Meurer
Hey Yang, Here's some simple cleanup. Please take a look. Thanks, Benedikt
3 years, 9 months ago (2017-03-15 12:22:49 UTC) #4
Yang
On 2017/03/15 12:22:49, Benedikt Meurer wrote: > Hey Yang, > > Here's some simple cleanup. ...
3 years, 9 months ago (2017-03-15 13:28:12 UTC) #8
Yang
On 2017/03/15 12:22:49, Benedikt Meurer wrote: > Hey Yang, > > Here's some simple cleanup. ...
3 years, 9 months ago (2017-03-15 13:28:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748253004/1
3 years, 9 months ago (2017-03-15 13:29:06 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 13:35:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ead696dc88add5d5416a273d9bccd8ef5d0...

Powered by Google App Engine
This is Rietveld 408576698