Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2748223002: Replace ASSERT_NOT_REACHED with NOTREACHED in core/svg/ (Closed)

Created:
3 years, 9 months ago by mrunal
Modified:
3 years, 9 months ago
Reviewers:
tkent, fs
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, fmalita+watch_chromium.org, fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT_NOT_REACHED with NOTREACHED in core/svg/ BUG=697687 Review-Url: https://codereview.chromium.org/2748223002 Cr-Commit-Position: refs/heads/master@{#456901} Committed: https://chromium.googlesource.com/chromium/src/+/cf49c415e86cf6b784a003426f2a5556eba950d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -49 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAngle.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedColor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGBoolean.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGEnumeration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLengthContext.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGParsingError.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathBlender.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathByteStreamBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathByteStreamSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathQuery.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathStringBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathStringSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPreserveAspectRatio.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGStaticStringList.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGStringList.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransform.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformDistance.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformList.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
mrunal
fs, PTAL.
3 years, 9 months ago (2017-03-14 22:02:30 UTC) #3
fs
lgtm
3 years, 9 months ago (2017-03-14 22:08:50 UTC) #4
tkent
lgtm
3 years, 9 months ago (2017-03-14 22:25:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748223002/1
3 years, 9 months ago (2017-03-14 22:25:50 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 00:01:42 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cf49c415e86cf6b784a003426f2a...

Powered by Google App Engine
This is Rietveld 408576698